From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9349060A261F for ; Thu, 29 Oct 2026 10:00:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=heJkXCAC; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=O73oQffq DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=R5j+yiYhCHq58JPEG4iD9M+YB5PgArKotbfDfonHirY=; b=heJkXCACg2O4nQUZl8Im00dulY 4Kb9cSD3W13/5l0MTVYSHBnPgqsOKM6yVEBrL+oLU8mqTh4cEzd6y7HNbjow14n0VkaDJdJ37WKF3 goVKn6TR8in0cNc3rg1hHUXzFHAdaoxBvVsiDbLW5iCHAMgymT3d+abPkrRL5Z2AMk0wnrtHJizna imevI2uUHlI0XPtjrv9KbT+hELHnn+ghHBpYuNwKH1ISczfIlJ+XwK1F6lxgWLFSUi41HyMWMTeb+ vU+tKSQR+qVr6gGSBvXq8ZoaGs2hj8XbCU2hxORWKOWYMhAHzXTLeestKTUufNDMe2FhFNKxhi/FI r3/90Y7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMMvR-00000008uof-1sld; Thu, 29 Oct 2026 10:00:01 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMMvQ-00000008uoQ-365S; Thu, 29 Oct 2026 10:00:00 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0694843B14; Thu, 29 Oct 2026 10:00:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27DE31F01825; Thu, 29 Oct 2026 09:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793267999; bh=R5j+yiYhCHq58JPEG4iD9M+YB5PgArKotbfDfonHirY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=O73oQffqeqikGDOuGDIY+NW2h/CpmNU5TKIWGZcmDMP/nIgRRBHUlxQ/rByvmxysZ 2DibCtTty4S0qQ9JYLUNQ2dkoJIfYb8Wg3hbow/0qw3zC5PBMT7ZxMHVn7cTHo7P2Q eHigrpfHtmmgho+MFCgSY57Bf3fA0P7yUHFhFVvfcWiY3qyFqifrEJNJT3kb10q7fr glHPWTJcD+Lxk+9D43PGxMBgpyc1vLVzeGu/TPAkP2mu3xRvW6L77MXJ9JtBs+0ddf BwJsHcek9yBt2zul90gA9wabFYrnGM5WS2elzRf2uumNpf+KWH+n9eTsTQmHKx/8s9 GLzP+X0yXxHbg== Date: Thu, 29 Oct 2026 09:59:54 +0000 From: Simon Horman To: netdev-bot+sashiko@kernel.org Cc: alex@goodkind.io, nbd@nbd.name, lorenzo@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, tarick@bedeir.com Subject: Re: [PATCH net] net: ethernet: mediatek: preserve sibling PPE bindings Message-ID: <20261029095954.GD257209@horms.kernel.org> References: <20261023012529.5994-1-alex@goodkind.io> <179306513862.3134.14236907013127690482@kernel.org> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <179306513862.3134.14236907013127690482@kernel.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Tue, Oct 27, 2026 at 01:38:58AM +0000, netdev-bot+sashiko@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential > issue(s) to consider. > > Critical: 0 · High: 1 · Medium: 0 (3) · Low: 0 > > If you believe none of the issues are legitimate, please reply to each > issue of Medium severity or higher and explain why the AI is wrong. > If any of them are legitimate and you plan to respin, please let patchwork > know by including "pw-bot: cr" as a separate line at the end of your reply > (one such reply per series is enough). > > - [High] The fix is incomplete: the L2_SUBFLOW branch of > __mtk_ppe_check_skb()… Hi Alexander, The issue above does seem to be of concern. Could you please respond to it? > > Pre-existing issues: > - [Medium] This problem wasn't introduced by this patch, but L2 (bridge) > flows never get the 0xffff 'unbound' sentinel in entry->hash. > - [Medium] This problem wasn't introduced by this patch, but > mtk_flow_offload_stats() reads entry->hash without ppe_lock: once for… > - [Medium] This problem wasn't introduced by this patch, but the MIB read > sequence in mtk_mib_entry_read() is not serialized. ...