All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Piparo <holofermes@gmail.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Amit Barzilai <amit.barzilai22@gmail.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Fabio Piparo <holofermes@gmail.com>
Subject: [PATCH 0/2] drm/ssd130x: Make the SSD1322 work
Date: Thu, 29 Oct 2026 16:57:49 -0400	[thread overview]
Message-ID: <20261029205751.3513474-1-holofermes@gmail.com> (raw)

The SSD1322 has been in the ssd130x match tables since the ssd132x
family was added, but that family was brought up on an SSD1327. The two
controllers share a RAM layout and many opcodes, but the SSD1322 takes
command parameters on the data path and differs in several commands.
This series gives the SSD1322 its own family, shaped like the ssd135x.

Mario Limonciello's connector luminance series [1], not merged yet,
sends the SSD130x contrast command to every family it does not know.
The SSD1322 does not have that command, so whichever series lands
second needs an SSD1322 case there.

Testing:

  - ZJY 3.12" 256x64 SSD1322 module on 4-wire SPI (mode 3) at 16 MHz,
    Raspberry Pi 5, Raspberry Pi rpi-7.3.y kernel (7.3.0-v8-16k+) with
    the ssd130x files from this series in tree. That tree also needed
    commit 3dcb0564c509 from drm-misc-next.
  - Without the series, a modeset and a full white frame leave the
    panel dark. With it, the frame is white as expected.
  - A KMS client at ~200 fps matches its rendered frames on the glass
    through a camera harness, at the default clock and with
    solomon,dclk-div = <1>.
  - Backlight brightness 0, 64, 127 and 255 moves the contrast on the
    glass.
  - solomon,dclk-div = <3> is refused with an error and no init is sent.

[1] https://lore.kernel.org/dri-devel/20261002190030.211356-22-mario.limonciello@amd.com/

Thanks,
Fabio

Fabio Piparo (2):
  dt-bindings: display: solomon,ssd132x: Add col-offset and dclk
    properties for the SSD1322
  drm/ssd130x: Add SSD1322_FAMILY and move the SSD1322 to it

 .../bindings/display/solomon,ssd132x.yaml     |  29 ++
 drivers/gpu/drm/solomon/ssd130x-i2c.c         |   3 +-
 drivers/gpu/drm/solomon/ssd130x-spi.c         |   6 +-
 drivers/gpu/drm/solomon/ssd130x.c             | 277 +++++++++++++++++-
 drivers/gpu/drm/solomon/ssd130x.h             |   4 +-
 5 files changed, 310 insertions(+), 9 deletions(-)


base-commit: 21803a577cc692d01307102799f795a606871212
-- 
2.53.0


             reply	other threads:[~2026-10-29 20:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 20:57 Fabio Piparo [this message]
2026-10-29 20:57 ` [PATCH 1/2] dt-bindings: display: solomon,ssd132x: Add col-offset and dclk properties for the SSD1322 Fabio Piparo
2026-10-29 20:57   ` [PATCH 1/2] dt-bindings: display: solomon, ssd132x: " Fabio Piparo
2026-10-29 20:57 ` [PATCH 2/2] drm/ssd130x: Add SSD1322_FAMILY and move the SSD1322 to it Fabio Piparo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261029205751.3513474-1-holofermes@gmail.com \
    --to=holofermes@gmail.com \
    --cc=airlied@gmail.com \
    --cc=amit.barzilai22@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mario.limonciello@amd.com \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.