All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: bo cao <treebacker@foxmail.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH] char: uv_mmtimer: prevent read-only mapping from becoming writable
Date: Thu, 29 Oct 2026 07:56:19 +0100	[thread overview]
Message-ID: <2026102935-corridor-surreal-ef51@gregkh> (raw)
In-Reply-To: <tencent_A595E3D79A2F77C2BA5A45A9874C46D55508@qq.com>

On Thu, Oct 29, 2026 at 11:54:13AM +0800, bo cao wrote:
> uv_mmtimer_mmap() rejects writable mappings but leaves VM_MAYWRITE
> set.  Userspace can map the clock's MMR page read-only and then
> upgrade the mapping to writable with mprotect(), gaining write access
> to the UVH_RTC register that the driver explicitly declares
> read-only.
> 
> Clear VM_MAYWRITE, as fixed in vfio/platform (commit 420bed9131db),
> drm/vc4 (CVE-2026-68445), drm/panthor (CVE-2024-53071) and
> ptp/vmclock (commit a5edadbae57e).
> 
> Note this is defensive hardening on two counts: /dev/uv_mmtimer is
> created with the default 0600 mode (exploitation requires root), and
> the driver only exists on SGI UV systems.
> 
> Fixes: fbd8ae106850 ("drivers/char/uv_mmtimer.c: add memory mapped RTC driver for UV")
> Signed-off-by: bo cao <treebacker@foxmail.com>
> ---
>  drivers/char/uv_mmtimer.c | 3 +++
>  1 file changed, 3 insertions(+)

Your LLM just picked up a patch I sent previously:
	https://lore.kernel.org/r/2026102752-extrovert-undaunted-d6cb@gregkh

thanks,

greg k-h

  reply	other threads:[~2026-10-29  6:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29  3:54 [PATCH] char: uv_mmtimer: prevent read-only mapping from becoming writable bo cao
2026-10-29  6:56 ` Greg KH [this message]
2026-10-29  7:09   ` bo cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026102935-corridor-surreal-ef51@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=treebacker@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.