From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5333B606A33B for ; Fri, 30 Oct 2026 10:28:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=bZcLkSiy Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B4163112711; Fri, 30 Oct 2026 10:27:56 +0000 (UTC) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id B8118112711; Fri, 30 Oct 2026 10:27:50 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id DEB72605CF; Fri, 30 Oct 2026 10:27:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 112351F000C1; Fri, 30 Oct 2026 10:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793356069; bh=RymG5Zs9FwMJtITbzdgvGCkoIgIBEM6um3giVlZIMck=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=bZcLkSiynlmM8mmekL2+i7H1+ZOSrbnf75FBYKtErwXYHPas26GMjT+dMEaTggWx0 ShLhUU0BjTuyOiAKjoe+iotdxyNGZZz3O9jD+Ggiu8nfRBKUfTTgpvpalwnSKUAkr2 k3NM/Vz7hXZC+Fx00HM3jz2hxhZJq7URdDstG2Y4oEolEVFJaoZQtB/Aiuj3kntd8l uMPrWQs+Niakas3pMR3C4rXu5zrOEJ09dgdoemimSVhIGLg1dRtkCxPTOXzouBc3j1 zstygkeZL0rl8KN27napRTH0HqhoVvxgqvJ7VG93zOv0VZK4gvxptNBuCfuspDC/Sq g2uB1fcF0mn8Q== From: Maxime Ripard Date: Fri, 30 Oct 2026 11:27:33 +0100 Subject: [PATCH v7 01/16] drm/amd/display: Fix planes atomic_create_state implementation X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20261030-drm-reset-state-flag-v7-1-4e55eaeae683@kernel.org> References: <20261030-drm-reset-state-flag-v7-0-4e55eaeae683@kernel.org> In-Reply-To: <20261030-drm-reset-state-flag-v7-0-4e55eaeae683@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: Daniel Stone , Harry Wentland , Jocelyn Falempe , =?utf-8?q?Jonas_=C3=85dahl?= , =?utf-8?q?Michel_D=C3=A4nzer?= , Pekka Paalanen , Sebastian Wick , Simon Ser , Victoria Brekenfeld , Xaver Hugl , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , amd-gfx@lists.freedesktop.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1628; i=mripard@kernel.org; h=from:subject:message-id; bh=HLVzeyqKpswstRmnOeZPJueli10TkjAEfdifLM4/WJw=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFlPCsWvWfD6/niZt29lWPjkBffXvTnOU7n88lmvBoOJn Hb58vWcHVNZGIQ5GWTFFFmeyISdXt6+uMrBfuUPmDmsTCBDGLg4BWAiZ70Y69TuL/SI+uT1kPnQ FMOQ7/Fzw97fF2nSSVDnO8PSGmAkckpg/dQDrU8mdqtJG32fsuvsf8b6hNRPW75M2C0eza543Wb Lw3M/jS6U5sw4tzwxoqJT6++co1yBvgv8r2W5mmzOl7izU5wJAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "dri-devel" X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Commit 2bcec01cf105 ("drm/amdgpu_dm: Convert to atomic_create_state") converted the amdgpu planes to use atomic_create_state instead of reset. Unlike reset, atomic_create_state is meant to allocate a new default state without any side effect on the hardware or software state. However, during the conversion we forgot to remove the call to destroy the existing plane state if any. While this was expected from a reset implementation, it's not for an atomic_create_state one. Remove it. Fixes: 2bcec01cf105 ("drm/amdgpu_dm: Convert to atomic_create_state") Signed-off-by: Maxime Ripard --- To: Harry Wentland To: Leo Li To: Rodrigo Siqueira To: Alex Deucher To: Christian König Cc: amd-gfx@lists.freedesktop.org --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c index 2f88b9d65b82..779dabb7fc51 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c @@ -1821,7 +1821,4 @@ STATIC_IFN_KUNIT struct drm_plane_state *amdgpu_dm_plane_drm_plane_create_state( } - if (plane->state) - plane->funcs->atomic_destroy_state(plane, plane->state); - __drm_atomic_helper_plane_state_init(&amdgpu_state->base, plane); amdgpu_state->degamma_tf = AMDGPU_TRANSFER_FUNCTION_DEFAULT; -- 2.55.0