From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F7EB60A3808 for ; Fri, 30 Oct 2026 10:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Jn5BsOwB Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B35D112722; Fri, 30 Oct 2026 10:28:26 +0000 (UTC) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D5BE11271B for ; Fri, 30 Oct 2026 10:27:58 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 843D960617; Fri, 30 Oct 2026 10:27:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B066D1F00A02; Fri, 30 Oct 2026 10:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793356077; bh=bp8Sv56uWGNu5dzO8hoWLI+wBl8bSINfQ15wCZlMHhg=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Jn5BsOwBaa7ZGUBOzwVlDte10ZHifykzg9wPsWl+gcAvDYa2XjovQ9wk4SHgaEn0t N2eUajxt4ySosFNKDLZdSVEVVlC60QiZ6QfHYOW8gEcF/4Nolo5d7EHzBBiEih4czQ Ko4mYZdB+UC0CjB4hDLkESorlcx7Y3I3E3qai3u9ZWpqPKEZ7aaCy3fgMWnd3njCbj IwC3aY3yeOyGv69vLIzMOoujxIargMAxRX4chmK1dxGPSJEARGTPNLeeK6qNCOjkIV aFUQDTaHlQc+5QccjYhqSVscgtTImb2cyQ12jcu/4BcelhPBfuwwnZLjnjP8R51qc1 /K1+odhRlXh8w== From: Maxime Ripard Date: Fri, 30 Oct 2026 11:27:35 +0100 Subject: [PATCH v7 03/16] drm/atomic: Switch to krealloc_array() in drm_atomic_get_private_obj_state() X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261030-drm-reset-state-flag-v7-3-4e55eaeae683@kernel.org> References: <20261030-drm-reset-state-flag-v7-0-4e55eaeae683@kernel.org> In-Reply-To: <20261030-drm-reset-state-flag-v7-0-4e55eaeae683@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: Daniel Stone , Harry Wentland , Jocelyn Falempe , =?utf-8?q?Jonas_=C3=85dahl?= , =?utf-8?q?Michel_D=C3=A4nzer?= , Pekka Paalanen , Sebastian Wick , Simon Ser , Victoria Brekenfeld , Xaver Hugl , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1391; i=mripard@kernel.org; h=from:subject:message-id; bh=BzbEMPPA4chwGhrAev6Iwlnw4dYruoi/b+S/QBBvOnk=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFlPCiVM2uJ2r1vnICXVkFd+MYp505X6+d/L568yKkibG BR8ZMK7jqksDMKcDLJiiixPZMJOL29fXOVgv/IHzBxWJpAhDFycAjARY37Gep94z7z/5avVFzDU ZNmdY8xeE7i/1pf11oJDG67M4wpan317R0eCr9imfDlulshf/cdWMdZK597X6+4+dmB74a2ni5k TJ000qba4GqfD/uLA1Xfz80QFpj15yvjfcJpNwvPZPC+ir58BAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "dri-devel" X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The drm_atomic_get_private_obj_state() function manually computes the allocation size by multiplying the element count by the element size before passing it to krealloc(). krealloc_array() handles this multiplication internally and includes overflow checking. Switch to it and drop the now-unused size variable. Suggested-by: Thomas Zimmermann Reviewed-by: Daniel Stone Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 9bb761eda59f..aa47c647df31 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -1080,5 +1080,4 @@ drm_atomic_get_private_obj_state(struct drm_atomic_commit *state, { int index, num_objs, ret; - size_t size; struct __drm_private_objs_state *arr; struct drm_private_state *obj_state; @@ -1096,6 +1095,6 @@ drm_atomic_get_private_obj_state(struct drm_atomic_commit *state, num_objs = state->num_private_objs + 1; - size = sizeof(*state->private_objs) * num_objs; - arr = krealloc(state->private_objs, size, GFP_KERNEL); + arr = krealloc_array(state->private_objs, num_objs, + sizeof(*state->private_objs), GFP_KERNEL); if (!arr) return ERR_PTR(-ENOMEM); -- 2.55.0