All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [axboe:tty-nowait 15/21] fs/notify/inotify/inotify_user.c:698:16: error: 'fdf' is a pointer; did you mean to use '->'?
Date: Fri, 30 Oct 2026 00:58:42 +0100	[thread overview]
Message-ID: <202610300011.j6ebX0iz-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git tty-nowait
head:   6ce7bd6c31981898360c3e36c9c270b0215cd020
commit: 29b6c55defd03d6cd9ea2b19545a3b67fd618fa3 [15/21] inotify: convert read to read_iter
config: i386-allnoconfig-bpf (https://download.01.org/0day-ci/archive/20261030/202610300011.j6ebX0iz-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261030/202610300011.j6ebX0iz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610300011.j6ebX0iz-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/notify/inotify/inotify_user.c: In function 'do_inotify_init':
>> fs/notify/inotify/inotify_user.c:698:16: error: 'fdf' is a pointer; did you mean to use '->'?
     698 |         if (fdf.err) {
         |                ^
         |                ->
   fs/notify/inotify/inotify_user.c:700:27: error: 'fdf' is a pointer; did you mean to use '->'?
     700 |                 return fdf.err;
         |                           ^
         |                           ->


vim +698 fs/notify/inotify/inotify_user.c

   676	
   677	
   678	/* inotify syscalls */
   679	static int do_inotify_init(int flags)
   680	{
   681		struct fsnotify_group *group;
   682	
   683		/* Check the IN_* constants for consistency.  */
   684		BUILD_BUG_ON(IN_CLOEXEC != O_CLOEXEC);
   685		BUILD_BUG_ON(IN_NONBLOCK != O_NONBLOCK);
   686	
   687		if (flags & ~(IN_CLOEXEC | IN_NONBLOCK))
   688			return -EINVAL;
   689	
   690		/* fsnotify_obtain_group took a reference to group, we put this when we kill the file in the end */
   691		group = inotify_new_group(inotify_max_queued_events);
   692		if (IS_ERR(group))
   693			return PTR_ERR(group);
   694	
   695		FD_PREPARE(fdf, O_RDONLY | flags,
   696			   anon_inode_getfile_fmode("inotify", &inotify_fops, group,
   697						    O_RDONLY | flags, FMODE_NOWAIT));
 > 698		if (fdf.err) {
   699			fsnotify_destroy_group(group);
   700			return fdf.err;
   701		}
   702	
   703		return fd_publish(fdf);
   704	}
   705	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-10-29 23:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202610300011.j6ebX0iz-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=axboe@kernel.dk \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.