Re: [PATCH 09/15] iio: light: tsl2591: don't divide by zero in the dark

[Joshua Crofts <joshua.crofts1@gmail.com>]

On Tue, 27 Oct 2026 17:19:13 +0100
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> From: Josef Bacik <josef@toxicpanda.com>
> 
> The computation of the illuminance divides by the count of channel 0.
> That is the channel which sees the whole spectrum: in complete darkness it
> reads zero, and reading in_illuminance_input divides by zero.  Depending
> on the architecture this is an oops, a warning with a backtrace, or goes
> unnoticed.
> 
> Report 0 lux in that case.
> 
> Fixes: 2335f0d7c790 ("iio: light: Added AMS tsl2591 driver implementation")
> Cc: stable <stable@kernel.org>
> Cc: David Lechner <dlechner@baylibre.com>
> Cc: "Nuno Sá" <nuno.sa@analog.com>
> Cc: Andy Shevchenko <andy@kernel.org>
> Cc: Josef Bacik <josef@toxicpanda.com>
> Cc: Matheus Silveira <matheus.feitosa@usp.br>
> Cc: Lucas Rabaquim <lucas.rabaquim@usp.br>
> Cc: Stepan Ionichev <sozdayvek@gmail.com>
> Cc: Joe Sandom <joe.g.sandom@gmail.com>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---

Reviewed-by: Joshua Crofts <crofts@kernel.org>

-- 
Kind regards,
Joshua Crofts