From: Joshua Crofts <crofts@kernel.org>
To: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nuno Sa <nuno.sa@analog.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux@analog.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] staging: iio: addac: adt7316: explicitly include missing headers and sort
Date: Fri, 30 Oct 2026 12:40:40 +0100 [thread overview]
Message-ID: <20261030124040.00003db0@kernel.org> (raw)
In-Reply-To: <20261030104745.16693-3-abdelnasserhussein11@gmail.com>
On Fri, 30 Oct 2026 12:47:45 +0200
Abdelnasser Hussein <abdelnasserhussein11@gmail.com> wrote:
> Explicitly include <linux/err.h>, <linux/errno.h>, <linux/pm.h>,
> <linux/string.h>, and <linux/types.h> for error handling, error codes,
> EXPORT_GPL_SIMPLE_DEV_PM_OPS(), memcmp(), and fixed-width types. Drop
> unused headers and sort the remaining headers alphabetically.
>
Better if patch 1 only sorts the list and patch 2 removes kernel.h
and adds/removes headers - it will be more readable that way. Have
a look at this patch series I sent some time ago [1] for reference.
[1] https://lore.kernel.org/all/20260831-kernel-header-removal-v2-0-b92b580ef5eb@gmail.com/
--
Kind regards,
Joshua Crofts
prev parent reply other threads:[~2026-10-30 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 10:47 [PATCH v2 0/2] staging: iio: addac: adt7316: clean up header inclusions Abdelnasser Hussein
2026-10-30 10:47 ` [PATCH v2 1/2] staging: iio: addac: adt7316: replace kernel.h with bits.h and kstrtox.h Abdelnasser Hussein
2026-10-30 10:47 ` [PATCH v2 2/2] staging: iio: addac: adt7316: explicitly include missing headers and sort Abdelnasser Hussein
2026-10-30 11:40 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261030124040.00003db0@kernel.org \
--to=crofts@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=abdelnasserhussein11@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.