From: Junjie Cao <junjie.cao@linux.dev>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Fabiano Rosas" <farosas@suse.de>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
junjie.cao@linux.dev
Subject: [PATCH 0/2] hw/usb/hcd-xhci: check the DCBAA read in Address Device
Date: Fri, 30 Oct 2026 22:37:23 -0500 [thread overview]
Message-ID: <20261031033725.1275414-1-junjie.cao@linux.dev> (raw)
Address Device discards the result of the DCBAA entry read. With DCBAAP
pointing at unassigned memory the command still completes with Success
and the slot and ep0 contexts are written to guest address 0:
https://gitlab.com/qemu-project/qemu/-/issues/4706
The series keeps the existing HCE-only error signalling; halting the
controller on a failed host access, as xHCI 4.10.2.6 asks, is a
separate change. The post_load path has no test.
Tested on x86_64 with the reporter's reproducer (before: Success and
address 0 overwritten; after: TRB Error, HCE set, address 0 intact) and
the full usb-hcd-xhci-test.
Patch 2 touches the same test file as the #4658 series
(20261030165807.79423-1-tcalifano@redhat.com); the two apply in either
order with a 3-way merge.
Junjie Cao (2):
hw/usb/hcd-xhci: fail Address Device when the DCBAA entry is
unreadable
tests/qtest/usb-hcd-xhci: test Address Device with an unreadable DCBAA
hw/usb/hcd-xhci.c | 41 ++++++++++------
tests/qtest/usb-hcd-xhci-test.c | 87 ++++++++++++++++++++++++++++-----
2 files changed, 102 insertions(+), 26 deletions(-)
base-commit: 9703b6cf418d2ce72fae8d00e511135ce0bfda43
--
2.43.0
next reply other threads:[~2026-10-31 3:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 3:37 Junjie Cao [this message]
2026-10-31 3:37 ` [PATCH 1/2] hw/usb/hcd-xhci: fail Address Device when the DCBAA entry is unreadable Junjie Cao
2026-10-31 3:37 ` [PATCH 2/2] tests/qtest/usb-hcd-xhci: test Address Device with an unreadable DCBAA Junjie Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261031033725.1275414-1-junjie.cao@linux.dev \
--to=junjie.cao@linux.dev \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.