Re: [PATCH] Input: synaptics - support the touchpad LED on RMI function $30

[kernel test robot <lkp@intel.com>]

Hi ahmad,

kernel test robot noticed the following build errors:

[auto build test ERROR on dtor-input/next]
[also build test ERROR on dtor-input/for-linus hid/for-next linus/master v7.3 next-20261030]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/ahmad-baghereslami/Input-synaptics-support-the-touchpad-LED-on-RMI-function-30/20261030-103821
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link:    https://lore.kernel.org/r/20261030070821.1716595-1-ahmad.b1995%40gmail.com
patch subject: [PATCH] Input: synaptics - support the touchpad LED on RMI function $30
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20261031/202610311023.UR64jYrp-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261031/202610311023.UR64jYrp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610311023.UR64jYrp-lkp@intel.com/

All errors (new ones prefixed by >>):

   /usr/bin/ld: drivers/input/mouse/synaptics.o: in function `synaptics_disconnect':
>> drivers/input/mouse/synaptics.c:1678:(.text+0x3ec): undefined reference to `led_classdev_unregister'
   /usr/bin/ld: drivers/input/mouse/synaptics.o: in function `led_classdev_register':
>> include/linux/leds.h:274:(.text+0x12c9): undefined reference to `led_classdev_register_ext'
   collect2: error: ld returned 1 exit status


vim +1678 drivers/input/mouse/synaptics.c

  1668	
  1669	PSMOUSE_DEFINE_ATTR(disable_gesture, S_IWUSR | S_IRUGO, NULL,
  1670			    synaptics_show_disable_gesture,
  1671			    synaptics_set_disable_gesture);
  1672	
  1673	static void synaptics_disconnect(struct psmouse *psmouse)
  1674	{
  1675		struct synaptics_data *priv = psmouse->private;
  1676	
  1677		if (priv->has_rmi_led)
> 1678			led_classdev_unregister(&priv->rmi_led);
  1679	
  1680		/*
  1681		 * We might have left a breadcrumb when trying to
  1682		 * set up SMbus companion.
  1683		 */
  1684		psmouse_smbus_cleanup(psmouse);
  1685	
  1686		if (!priv->absolute_mode &&
  1687				SYN_ID_DISGEST_SUPPORTED(priv->info.identity))
  1688			device_remove_file(&psmouse->ps2dev.serio->dev,
  1689					   &psmouse_attr_disable_gesture.dattr);
  1690	
  1691		synaptics_reset(psmouse);
  1692		kfree(priv);
  1693		psmouse->private = NULL;
  1694	}
  1695	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki