All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Ho Jie Feng <hjf3108@gmail.com>
Cc: linux-wireless@vger.kernel.org, Kalle Valo <kvalo@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless-next 1/8] wifi: rt2x00: start the link tuner when an interface is added
Date: Sat, 31 Oct 2026 11:51:57 +0100	[thread overview]
Message-ID: <20261031105157.GA31143@wp.pl> (raw)
In-Reply-To: <20261029134752.1299130-2-hjf3108@gmail.com>

On Thu, Oct 29, 2026 at 09:47:42PM +0800, Ho Jie Feng wrote:
> rt2x00lib_start() enables the radio before mac80211 adds the first
> interface, so rt2x00link_start_tuner(), called from
> rt2x00lib_enable_radio(), finds no station or AP interface and returns.
> 
> Start the link tuner again when an interface is added.
> 
> Fixes: d96324703ffa ("rt2x00: merge agc and vco works with link tuner")
> Signed-off-by: Ho Jie Feng <hjf3108@gmail.com>
> ---
>  drivers/net/wireless/ralink/rt2x00/rt2x00mac.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00mac.c b/drivers/net/wireless/ralink/rt2x00/rt2x00mac.c
> index 3bc0c1c906c91..d9e323ccc6d62 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2x00mac.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00mac.c
> @@ -264,6 +264,12 @@ int rt2x00mac_add_interface(struct ieee80211_hw *hw,
>  	 */
>  	rt2x00dev->packet_filter = 0;
>  
> +	/*
> +	 * Start the link tuner again if the radio is enabled before the
> +	 * first interface is added.
> +	 */
> +	rt2x00link_start_tuner(rt2x00dev);
Maybe add (rt2x00dev->intf_ap_count + rt2x00dev->intf_sta_count == 1)
check, to prevent reset of the tuner if already running?
And add corresponding counter part when removing interface.

Regards
Stanislaw

> +
>  	return 0;
>  }
>  EXPORT_SYMBOL_GPL(rt2x00mac_add_interface);
> -- 
> 2.53.0
> 

  reply	other threads:[~2026-10-31 10:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 13:47 [PATCH wireless-next 0/8] wifi: rt2x00: improve the throughput of rt2800usb Ho Jie Feng
2026-10-29 13:47 ` [PATCH wireless-next 1/8] wifi: rt2x00: start the link tuner when an interface is added Ho Jie Feng
2026-10-31 10:51   ` Stanislaw Gruszka [this message]
2026-10-29 13:47 ` [PATCH wireless-next 2/8] wifi: rt2800: calibrate the crystal of RT3593 with the beacons Ho Jie Feng
2026-10-31 10:52   ` Stanislaw Gruszka
2026-10-29 13:47 ` [PATCH wireless-next 3/8] wifi: rt2800: use the 3SS fallback table of RT3883 on RT3593 Ho Jie Feng
2026-10-29 13:47 ` [PATCH wireless-next 4/8] wifi: rt2800: report the MCS16 to MCS8 fallback of RT3593 in TX status Ho Jie Feng
2026-10-31 10:54   ` Stanislaw Gruszka
2026-10-29 13:47 ` [PATCH wireless-next 5/8] wifi: rt2800: don't report an A-MPDU length to minstrel_ht Ho Jie Feng
2026-10-29 13:47 ` [PATCH wireless-next 6/8] wifi: rt2800: set the mac80211 fast-xmit and aggregation flags Ho Jie Feng
2026-10-30  9:17   ` Stanislaw Gruszka
2026-10-30 11:33     ` Jie Feng
2026-10-31 11:06       ` Stanislaw Gruszka
2026-10-29 13:47 ` [PATCH wireless-next 7/8] wifi: rt2800usb: enable RX bulk aggregation Ho Jie Feng
2026-10-29 13:47 ` [PATCH wireless-next 8/8] wifi: rt2x00usb: use a threaded NAPI with GRO for RX Ho Jie Feng
2026-10-30  9:10 ` [PATCH wireless-next 0/8] wifi: rt2x00: improve the throughput of rt2800usb Stanislaw Gruszka
2026-10-30 11:30   ` Jie Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261031105157.GA31143@wp.pl \
    --to=stf_xl@wp.pl \
    --cc=hjf3108@gmail.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.