Re: [PATCH] sequencer: refuse to revert shallow boundary commits by default

[Nakul V S <vsnakul@gmail.com>]

Hi Phillip,

Thanks for the review. I've sent a v2 that addresses it:
https://lore.kernel.org/git/pull.2273.v2.git.1793455522168.gitgitgadget@gmail.com

> I wonder if it would be better to refuse to cherry-pick and rebase a
> shallow boundary commit as well.

Yes, I think so. v2 covers revert, cherry-pick and rebase, including
the "apply" backend of rebase.

> Do you know of a sensible use for reverting a shallow boundary or is
> the new option added out of caution in case someone wants it?

Honestly it was out of caution.I can't think of a real use for it. v2 keeps --allow-shallow-boundary for revert and cherry-pick only, and rebase always refuses. If you'd
rather not have an escape hatch at all, I'm happy to drop it.

> For such a rarely used option I don't think we need to add it to the
> synopsis

Fair enough, it's out of the synopsis now.

> It would be good to extract this into a helper function so that we
> don't have to copy the code to detect a shallow boundary each time we
> need to detect one.

Done. There is one helper now, so the error message lives in a single
place.

Thanks,
Nakul