From: Asdlerto Korry <korryasdlerto@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Pengyu Luo <mitltlatltl@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Asdlerto Korry <korryasdlerto@gmail.com>
Subject: [PATCH] usb: typec: ucsi: Fix printing of a fwnode with %pOFn
Date: Mon, 2 Nov 2026 02:35:08 +0200 [thread overview]
Message-ID: <20261102003508.341309-1-korryasdlerto@gmail.com> (raw)
ucsi_glink and ucsi_huawei_gaokun walk the connector nodes with
device_for_each_child_node(), which yields a struct fwnode_handle, but
print it with %pOFn, which expects a struct device_node. vsprintf then
treats the fwnode_handle as a device_node and calls fwnode_get_name()
on a pointer into the middle of it, so the "missing reg property" error
path oopses instead of printing the message (seen with the same code in
pmic_glink_altmode on a Samsung Galaxy M52 5G).
Use %pfwP, the specifier for the name of a fwnode.
Fixes: c6165ed2f425 ("usb: ucsi: glink: use the connector orientation GPIO to provide switch events")
Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
Signed-off-by: Asdlerto Korry <korryasdlerto@gmail.com>
---
drivers/usb/typec/ucsi/ucsi_glink.c | 2 +-
drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c
index 1db0c88d817e..4b4905624d61 100644
--- a/drivers/usb/typec/ucsi/ucsi_glink.c
+++ b/drivers/usb/typec/ucsi/ucsi_glink.c
@@ -433,7 +433,7 @@ static int pmic_glink_ucsi_probe(struct auxiliary_device *adev,
ret = fwnode_property_read_u32(fwnode, "reg", &port);
if (ret < 0) {
- dev_err(dev, "missing reg property of %pOFn\n", fwnode);
+ dev_err(dev, "missing reg property of %pfwP\n", fwnode);
return ret;
}
diff --git a/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c b/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c
index 57b37fca150c..fc74c205181e 100644
--- a/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c
+++ b/drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c
@@ -430,7 +430,7 @@ static int gaokun_ucsi_ports_init(struct gaokun_ucsi *uec)
device_for_each_child_node(dev, fwnode) {
ret = fwnode_property_read_u32(fwnode, "reg", &port);
if (ret < 0) {
- dev_err(dev, "missing reg property of %pOFn\n", fwnode);
+ dev_err(dev, "missing reg property of %pfwP\n", fwnode);
fwnode_handle_put(fwnode);
return ret;
}
--
2.25.1
next reply other threads:[~2026-11-02 0:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 0:35 Asdlerto Korry [this message]
2026-11-02 0:41 ` [PATCH] usb: typec: ucsi: Fix printing of a fwnode with %pOFn sashiko-bot
2026-11-02 8:49 ` Konrad Dybcio
2026-11-06 12:34 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102003508.341309-1-korryasdlerto@gmail.com \
--to=korryasdlerto@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mitltlatltl@gmail.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.