Re: [PATCH v3 0/2] staging: iio: addac: adt7316: clean up header inclusions

[Joshua Crofts <crofts@kernel.org>]

On Mon,  2 Nov 2026 11:42:34 +0200
Abdelnasser Hussein <abdelnasserhussein11@gmail.com> wrote:

> This series cleans up header inclusions in adt7316.c by following
> the Include What You Use (IWYU) principle.
> 
> The series is split into two logical steps:
> 1. Sort existing header inclusions alphabetically without modifying the
>    list of included headers. Keep subsystem <linux/iio/*> headers
>    separated and insert a blank line before "adt7316.h".
> 2. Drop proxy header <linux/kernel.h>, explicitly add missing headers
>    (<linux/bits.h>, <linux/err.h>, <linux/errno.h>, <linux/kstrtox.h>,
>    <linux/pm.h>, <linux/string.h>, <linux/types.h>), drop unused headers
>    (<linux/i2c.h>, <linux/list.h>, <linux/rtc.h>, <linux/slab.h>,
>    <linux/workqueue.h>), and maintain alphabetical sorting.
> 
> v3:
>  - Split the series as suggested by Joshua Crofts: patch 1 only sorts
>    the headers, patch 2 replaces kernel.h and adds/drops headers.
>  - Explicitly include <linux/err.h>, <linux/errno.h>, and
>    <linux/types.h> per IWYU following verification of symbols used.
> 
> v2:
>  - Address review feedback from Andy Shevchenko: drop <linux/kernel.h>
>    and include the headers actually used.
>  - Split the original patch into a 2-patch series.
> 
> v1:
>  - Initial submission.
> 
> Abdelnasser Hussein (2):
>   staging: iio: addac: adt7316: sort headers alphabetically
>   staging: iio: addac: adt7316: replace kernel.h with explicit headers
> 
>  drivers/staging/iio/addac/adt7316.c | 22 ++++++++++++----------
>  1 file changed, 12 insertions(+), 10 deletions(-)
> 

Much more readable in this order.

Reviewed-by: Joshua Crofts <crofts@kernel.org>

-- 
Kind regards,
Joshua Crofts