From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 862FF606AA28 for ; Mon, 2 Nov 2026 12:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AOa7d8/Z Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xNr4s-00064x-7H; Mon, 02 Nov 2026 07:23:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xNr4q-00063v-H4 for qemu-devel@nongnu.org; Mon, 02 Nov 2026 07:23:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xNr4p-0001Oi-34 for qemu-devel@nongnu.org; Mon, 02 Nov 2026 07:23:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793622230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WsHNdQtZtCNpOdHGiQz8M0Lrc6R9PPsR9IW5PJ13YMo=; b=AOa7d8/ZQ072Btr45agXwfkLFIyG+k58/2axT6z0YwLliNK7CU3+OgCy2Nom4wqHcTYrPB r02KAu3maxm0i7F3dx5kbZvKLs2P342DuoIcMDEqh1yAhOloyf1UqcgJVR+9+K580ChWzw v1+VpmWPF9YHcRHyb13AhpMXBQjDW4A= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-172-UAycB7GzNtGgsIZGE_vkbg-1; Mon, 02 Nov 2026 07:23:46 -0500 X-MC-Unique: UAycB7GzNtGgsIZGE_vkbg-1 X-Mimecast-MFC-AGG-ID: UAycB7GzNtGgsIZGE_vkbg_1793622225 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9F3621954B25; Mon, 2 Nov 2026 12:23:45 +0000 (UTC) Received: from berrange.csb (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AA8941800480; Mon, 2 Nov 2026 12:23:44 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v2 0/4] crypto: robustness fixes to handling of SM3 hash Date: Mon, 2 Nov 2026 12:23:39 +0000 Message-ID: <20261102122343.3348956-1-berrange@redhat.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Note that patch 4 is best reviewed by applying to git and then using 'git show -b' to hide the huge whitespace indentation change. Changed in v2: * Use array range initializer for setting default value * Drop redundant countermeasures now we can gurantee a correct default initializer value * Drop SM3 conditions in tests * Refactor tests to register one test per algorithm Daniel P. Berrangé (4): crypto: set default initializer hmac/hash arrays to -1 crypto: unconditionally report SM3 hash length tests/unit: drop conditionals for SM3 tests/unit: register one test per hash/hmac algorithm crypto/hash-glib.c | 3 +- crypto/hash.c | 4 +- crypto/hmac-glib.c | 4 +- tests/unit/test-crypto-hash.c | 325 +++++++++++++++------------------- tests/unit/test-crypto-hmac.c | 272 +++++++++++++--------------- 5 files changed, 275 insertions(+), 333 deletions(-) -- 2.56.0