From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.50 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793638429; b=d0ytCYOXy1KncdzFKEGdepXIkc9j2B7XXpeLeP82kgu7tsdVJn2TMfbUlo8lbEl/du4y le9djMZOUX7LjjUbvlovOwr5BjcXeE4KmKXQ1hYWHGmwytMYP8NHcU5hVgBiOgZGlLGBl iaKW0UG0lyyokWrIniGKaB5PlpeKh7+Q7wqk9KexlUBSdEdd4JcuvyFmmXtkK+xkvcqdg 4tOWmi5S7jU0JK7vVOvJQAIa3y7DyGBthJCJ3UDDHqe1AQOj26bk6KnPiIwgG7Z0tW5Dx ZDiGqGnIAng0RGAODDr2cYQeTe0f+DFJlcZO7LS/pGNszyxfkfCi/G7F4W7tL69LeMA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793638429; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=EZDrRuQAiBl+0xBpIr74aEBgz8ZqoT3E1SlQYBO5nWw=; b=mKumVCQI7Xjxh/bEjBzgVbXsPW7iojV4ogR09kOsRkc/S7vGcC01VDQ92MK0g0dUPkcf 4IzCFj1FlQq3cTeMeGcg6F17UgMgMqySs5haH7EXl7Qvm6/tU/hVll9FhMa0OGu8FteQU CmOSRa+/wLDJ63DLa4C60/SAda3qzDfcOx5tQC2bdcYosqihzvtCxWJ2osIPUzCEd37pn CnxMOdI+ryzwKTRlaEaHy0GqrhTtwnW6ihYYk+de+4Msdra14uhDu8rirdunxmyITe9h1 QYYTAcv9ApaYPoat3lzjMfvukUTDekQqilY93JvW4T2+Iqrfrl/FfzrJkoqPM8vpM1Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=vKMIkw1i; arc=none smtp.remote-ip=209.85.221.50 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 441DF6079069 for ; Mon, 2 Nov 2026 16:53:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 441DF6079069 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=vKMIkw1i Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-48bbb06e746so1501490f8f.3 for ; Mon, 02 Nov 2026 08:53:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793638427; x=1794243227; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EZDrRuQAiBl+0xBpIr74aEBgz8ZqoT3E1SlQYBO5nWw=; b=vKMIkw1iqSMJK/cBwek1vfZ/ITnN6S0fylaZjWFbrE0M1vNq5QwgV6ZSOmME6H7JQG jp69OZLbTe7D3qmIlP4Q2acbUGUkK+YCFqoslNRxnkbPH3mfuXU/TvJIIpkjO15sLXEM S9LwFYcHybz2eXXsFAjB3ymLuCS+efsqIkX+n8zm0tkNuQljKBEihAwM42Snog78uFjj 2BCFEXYqtE0Oe/PtDzjtELlAfdAZotCuEAS0WrPAvyWXyxf4Caj2BIoNGAlWMxyuNEWh FoglrIetER88ZHsOsF+fJwXzAPg++usAqqIbn8J1vD2Umu9mRTKN4ohg+9XtNVbCs0Gl iOeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793638427; x=1794243227; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=EZDrRuQAiBl+0xBpIr74aEBgz8ZqoT3E1SlQYBO5nWw=; b=VQn0b4ZW3hackP8fCNpXnfbsIgn8LQ2Q67wyRZoIQuoLotGc/uxN8fOji5iLLKxr0A gyZMpfDtMTsTIdoIJFPtfAwWjhvOlTLR1gxlmT3Docujt+3Sw+nkHYWUW65CKZhwG+tn W22OUAuHMaWANbVHj6cfyLxVJYoFgnHqUX8wvtoz82hDUYD2N3fzpzU1Yb2Qv8rrNdHu F8FcuO6amkP3D2sAIgMJvn80F1bY0NJkeHU3jqbjKzrjlPH7wsbHuT4vTd5cX6Hmu3e/ r4uNgJ/lN0CN3oTnZBT3VW0qg3HFoNtPptFa9AUOhbcYzpM2YUJcYENKYftBQ9Jhp3+E lZEw== X-Forwarded-Encrypted: i=1; AKwUvBxlgsFwYdQN2eoAz3T7/PsVP46nMVWg+BI3+dIgll1tyY3bj97DcQLkmAHvaGRnxRNndcrLe/jqGdfVgg==@vger.kernel.org X-Gm-Message-State: APuU4Z+3H2Eg6PhN9uqKpGy6xNtDug+TPmCaeAUZnaOJ/j/sSY20c5W7 hNTRvVXJ0yKi3lXlqax9/UxC0mGUzogezYMBhylvgVgJpQMH6sQHGEk= X-Gm-Gg: AYBFou3lr5i7tG6y14GYgm7nIxK9IgmvN6sr8fVYPOvQczxp+V4tOS1/bq0MHoD+gNz 5dzPvUTNpMcvHtKslPGiZjxxlRFtFDkMmGpNiRb2daqNptuYNK0iFHsJeN5ulIn/T7rFdOYhMXk Hq7Q7ezlx0hBXiooB7RemdeeftPox19LBaxwXiS1nHio6B0oBQTgZacUeiEpePfbUPT8aUfsiKp pzWOiDw98OkHf86YS9JIWa4pXoIG29a8CQ7S6fvlUBt17thAY5lD23zOgWSwXyV0FvuyrHdEPFH 2U/ZkGuPsnXDL9TPLY8uPNOz4ZoMVZKbMlw8R3i/1EJmeFpFNRPsuxYHIa6uIVwlM9MZ/PwZfe6 8IrttDR51XWwLJAVhjNSNXHF01U8bsB/VQKgxxbkJg6y2NgG7eOgil9DkjMuiolWwNmCzG5inrH 3Gi2Xi9nOFfMdnAgoEhp9CUUbtNJ7qMmKE7FJ7f0GhLQDx+isEXsYC76UN2dRe93fc30psIt3do eXHLPgYlfvIEuf5S9n5blUvxsflJ7A8Qcz+dA8jXclBmdQhXof//9iLpv9SN7WndD62NvPIbA== X-Received: by 2002:a05:6000:250a:b0:48a:f073:336b with SMTP id ffacd0b85a97d-48e6e2fcd88mr23121063f8f.23.1793638427498; Mon, 02 Nov 2026 08:53:47 -0800 (PST) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e71b8e5f4sm21479385f8f.40.2026.11.02.08.53.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 08:53:46 -0800 (PST) From: Tristan Madani To: Mark Brown , Liam Girdwood Cc: Charles Keepax , Oder Chiou , Bard Liao , Jaroslav Kysela , Takashi Iwai , Jorge Eduardo Candelaria , Margarita Olaya Cabrera , Misael Lopez Cruz , patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, tristan@talencesecurity.com Subject: [PATCH v6 1/4] ASoC: rt5668: cancel delayed works on component removal Date: Mon, 2 Nov 2026 16:53:37 +0000 Message-ID: <20261102165340.1558853-2-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261102165340.1558853-1-tristmd@gmail.com> References: <20261102165340.1558853-1-tristmd@gmail.com> X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani rt5668_remove() does not disable the IRQ or cancel the pending jack_detect_work and jd_check_work delayed works. If the component is unbound while work is pending, the handlers access freed memory. Track IRQ acquisition in rt5668_i2c_probe() via an irq_acquired flag. In rt5668_remove(), disable the IRQ (if acquired) and cancel both delayed works before resetting the codec. Re-enable the IRQ in rt5668_probe() when a sound card rebinds to prevent permanent IRQ silencing across card unbind/rebind cycles. Fixes: d59fb2856223 ("ASoC: rt5668: add rt5668B codec driver") Cc: stable@vger.kernel.org Signed-off-by: Tristan Madani --- sound/soc/codecs/rt5668.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5668.c b/sound/soc/codecs/rt5668.c index cd6245d6b91af..29d70802a046a 100644 --- a/sound/soc/codecs/rt5668.c +++ b/sound/soc/codecs/rt5668.c @@ -62,6 +62,9 @@ struct rt5668_priv { int pll_out; int jack_type; + + bool irq_acquired; + bool irq_disabled; }; static const struct reg_default rt5668_reg[] = { @@ -2216,12 +2219,26 @@ static int rt5668_probe(struct snd_soc_component *component) rt5668->component = component; + if (rt5668->irq_disabled) { + enable_irq(to_i2c_client(component->dev)->irq); + rt5668->irq_disabled = false; + } + return 0; } static void rt5668_remove(struct snd_soc_component *component) { struct rt5668_priv *rt5668 = snd_soc_component_get_drvdata(component); + struct i2c_client *i2c = to_i2c_client(component->dev); + + if (rt5668->irq_acquired) { + disable_irq(i2c->irq); + rt5668->irq_disabled = true; + } + + cancel_delayed_work_sync(&rt5668->jack_detect_work); + cancel_delayed_work_sync(&rt5668->jd_check_work); rt5668_reset(rt5668->regmap); } @@ -2555,7 +2572,8 @@ static int rt5668_i2c_probe(struct i2c_client *i2c) | IRQF_ONESHOT, "rt5668", rt5668); if (ret) dev_err(&i2c->dev, "Failed to request IRQ: %d\n", ret); - + else + rt5668->irq_acquired = true; } return devm_snd_soc_register_component(&i2c->dev, &soc_component_dev_rt5668, -- 2.47.3