From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: fix recovery of partial attr removals
Date: Tue, 3 Nov 2026 08:49:53 +0100 [thread overview]
Message-ID: <20261103074953.GD3678@lst.de> (raw)
In-Reply-To: <auh1xhogpIaw2d5t@nidhogg.toxiclabs.cc>
On Mon, Nov 02, 2026 at 12:52:38PM +0100, Carlos Maiolino wrote:
> Uff.. I think this goes waaaay back, even before CRC?!
The logic yes. I don't think the bug was there. The other interesting
bit is that back in the day the INCOMPLETE flag was only ever set when
removing a remote attribute. I think this made sense, as there's no
point in setting it for a local form one.
> Giving this wasn't a proble before LARP, I'd probably be inclined to set
> a Fixes pointing towards 1d08e11d04d2.
>
> Not because it imminently fixes that patch, but that the broken behavior
> kind of started after that. Cc stable probably v5.19. I don't think
> there is any point before that.
Fine with me if no one chouts. I assume you'll just add it?
next prev parent reply other threads:[~2026-11-03 7:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 8:09 [PATCH] xfs: fix recovery of partial attr removals Christoph Hellwig
2026-11-02 11:52 ` Carlos Maiolino
2026-11-03 7:49 ` Christoph Hellwig [this message]
2026-11-03 8:15 ` Carlos Maiolino
2026-11-04 14:11 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103074953.GD3678@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.