From: Christian Marangi <ansuelsmth@gmail.com>
To: Stefan Roese <sr@denx.de>, Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: Christian Marangi <ansuelsmth@gmail.com>
Subject: [PATCH v3 2/2] i2c: mt7621: limit SCL_STRETCH only to Mediatek SoC
Date: Tue, 3 Nov 2026 22:05:41 +0100 [thread overview]
Message-ID: <20261103210542.15965-2-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20261103210542.15965-1-ansuelsmth@gmail.com>
The same I2C driver is also used for Airoha SoC with the only difference
that the i2c_reset should not enable SCL_STRETCH for Airoha SoC.
Introduce a new compatible for Airoha and limit the SCL_STRETCH only to
Mediatek SoC.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
Changes v2:
- Use match data for storage
drivers/i2c/busses/i2c-mt7621.c | 25 ++++++++++++++++++++++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mt7621.c b/drivers/i2c/busses/i2c-mt7621.c
index 0a288c998419..fa1f32d4f046 100644
--- a/drivers/i2c/busses/i2c-mt7621.c
+++ b/drivers/i2c/busses/i2c-mt7621.c
@@ -57,9 +57,14 @@
/* timeout waiting for I2C devices to respond */
#define TIMEOUT_MS 1000
+struct mtk_i2c_data {
+ bool have_scl_stretch;
+};
+
struct mtk_i2c {
void __iomem *base;
struct device *dev;
+ const struct mtk_i2c_data *data;
struct i2c_adapter adap;
u32 bus_freq;
u32 clk_div;
@@ -83,6 +88,7 @@ static int mtk_i2c_wait_idle(struct mtk_i2c *i2c)
static void mtk_i2c_reset(struct mtk_i2c *i2c)
{
+ u32 reg;
int ret;
ret = device_reset(i2c->adap.dev.parent);
@@ -93,8 +99,11 @@ static void mtk_i2c_reset(struct mtk_i2c *i2c)
* Don't set SM0CTL0_ODRAIN as its bit meaning is inverted. To
* configure open-drain mode, this bit needs to be cleared.
*/
- iowrite32(((i2c->clk_div << 16) & SM0CTL0_CLK_DIV_MASK) | SM0CTL0_EN |
- SM0CTL0_SCL_STRETCH, i2c->base + REG_SM0CTL0_REG);
+ reg = ((i2c->clk_div << 16) & SM0CTL0_CLK_DIV_MASK) | SM0CTL0_EN;
+ if (i2c->data->have_scl_stretch)
+ reg |= SM0CTL0_SCL_STRETCH;
+
+ iowrite32(reg, i2c->base + REG_SM0CTL0_REG);
iowrite32(0, i2c->base + REG_SM0CFG2_REG);
}
@@ -247,8 +256,17 @@ static const struct i2c_algorithm mtk_i2c_algo = {
.functionality = mtk_i2c_func,
};
+static const struct mtk_i2c_data i2c_mt7621_data = {
+ .have_scl_stretch = true,
+};
+
+static const struct mtk_i2c_data i2c_an7581_data = {
+ .have_scl_stretch = false,
+};
+
static const struct of_device_id i2c_mtk_dt_ids[] = {
- { .compatible = "mediatek,mt7621-i2c" },
+ { .compatible = "mediatek,mt7621-i2c", .data = &i2c_mt7621_data },
+ { .compatible = "airoha,an7581-i2c", .data = &i2c_an7581_data },
{ /* sentinel */ }
};
@@ -286,6 +304,7 @@ static int mtk_i2c_probe(struct platform_device *pdev)
}
i2c->dev = &pdev->dev;
+ i2c->data = device_get_match_data(&pdev->dev);
if (of_property_read_u32(pdev->dev.of_node, "clock-frequency",
&i2c->bus_freq))
--
2.55.0
next prev parent reply other threads:[~2026-11-03 21:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 21:05 [PATCH v3 1/2] dt-bindings: i2c: mt7621: Document an7581 compatible Christian Marangi
2026-11-03 21:05 ` Christian Marangi [this message]
2026-11-10 11:11 ` [PATCH v3 2/2] i2c: mt7621: limit SCL_STRETCH only to Mediatek SoC Wolfram Sang
2026-11-10 11:11 ` [PATCH v3 1/2] dt-bindings: i2c: mt7621: Document an7581 compatible Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103210542.15965-2-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.