From: Christoph Hellwig <hch@lst.de>
To: mt4022@columbia.edu
Cc: Jens Axboe <axboe@kernel.dk>,
Mohamed Khalfella <mkhalfella@purestorage.com>,
Keith Busch <kbusch@kernel.org>, Ming Lei <tom.leiming@gmail.com>,
Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@lst.de>,
Nilay Shroff <nilay@linux.ibm.com>,
Josef Bacik <josef@toxicpanda.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
tz2294@columbia.edu, stable@vger.kernel.org
Subject: Re: [PATCH] blk-mq: take quiesce_lock when removing a queue from the tag set
Date: Wed, 4 Nov 2026 08:19:26 +0100 [thread overview]
Message-ID: <20261104071926.GA29136@lst.de> (raw)
In-Reply-To: <20261103-blk-mq-del-quiesce-lock-v1-1-04aa29a481f6@columbia.edu>
Looks good, but the note from Mohamed should be taken into account.
Or even better add a guarded_by so that clang catches this (requires
actualy compile testing with clang, though).
next prev parent reply other threads:[~2026-11-04 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 19:04 [PATCH] blk-mq: take quiesce_lock when removing a queue from the tag set Mani Tofigh via B4 Relay
2026-11-03 19:04 ` Mani Tofigh
2026-11-03 19:51 ` Mohamed Khalfella
2026-11-04 7:19 ` Christoph Hellwig [this message]
2026-11-04 13:26 ` Nilay Shroff
2026-11-04 13:19 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104071926.GA29136@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=josef@toxicpanda.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkhalfella@purestorage.com \
--cc=mt4022@columbia.edu \
--cc=nilay@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=tom.leiming@gmail.com \
--cc=tz2294@columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.