Re: [PATCH 4/5] rtc: Add basic support for RTC via Surface System Aggregator Module

[Alexandre Belloni <alexandre.belloni@bootlin.com>]

On 04/11/2026 04:04:35-0300, Val Packett wrote:
> +static void surface_rtc_remove(struct ssam_device *sdev)
> +{
> +	/* Device-managed allocations take care of everything... */
> +}
> +

I guess the function can simply be dropped then. Else, this looks good
to me.

> +static const struct ssam_device_id surface_rtc_match[] = {
> +	{ SSAM_SDEV(SAM, SAM, 0x00, 0x00) },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(ssam, surface_rtc_match);
> +
> +static struct ssam_device_driver surface_rtc_driver = {
> +	.probe = surface_rtc_probe,
> +	.remove = surface_rtc_remove,
> +	.match_table = surface_rtc_match,
> +	.driver = {
> +		.name = "surface_rtc",
> +		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
> +	},
> +};
> +module_ssam_device_driver(surface_rtc_driver);
> +
> +MODULE_AUTHOR("Maximilian Luz <luzmaximilian@gmail.com>");
> +MODULE_DESCRIPTION("RTC driver for Surface System Aggregator Module");
> +MODULE_LICENSE("GPL");
> -- 
> 2.56.0
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com