All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	xen-devel@lists.xenproject.org, qemu-ppc@nongnu.org,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Anthony PERARD" <anthony@xenproject.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Alexey Kardashevskiy" <aik@ozlabs.ru>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Helge Deller" <deller@gmx.de>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PULL v2 06/25] trace: drop unused trace_event_set_state_dynamic_init()
Date: Wed,  4 Nov 2026 15:17:42 -0500	[thread overview]
Message-ID: <20261104201802.11556-7-stefanha@redhat.com> (raw)
In-Reply-To: <20261104201802.11556-1-stefanha@redhat.com>

From: Daniel P. Berrangé <berrange@redhat.com>

The use of this method was mistakenly dropped in 0d4e995c73.
When the 'vcpu' property was dropped, however, this became
functionally identical to trace_event_set_state_dynamic().

Fixes: 0d4e995c7368 ("trace: convert code to use event iterators")
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20261102142844.3464712-7-berrange@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 trace/event-internal.h |  2 --
 stubs/trace-control.c  |  5 -----
 trace/control-target.c | 21 ---------------------
 3 files changed, 28 deletions(-)

diff --git a/trace/event-internal.h b/trace/event-internal.h
index 0c24e01b521..1d57b0ff1b5 100644
--- a/trace/event-internal.h
+++ b/trace/event-internal.h
@@ -37,6 +37,4 @@ typedef struct TraceEvent {
     uint16_t *dstate;
 } TraceEvent;
 
-void trace_event_set_state_dynamic_init(TraceEvent *ev, bool state);
-
 #endif /* TRACE__EVENT_INTERNAL_H */
diff --git a/stubs/trace-control.c b/stubs/trace-control.c
index b428f34c878..3f196835db0 100644
--- a/stubs/trace-control.c
+++ b/stubs/trace-control.c
@@ -11,11 +11,6 @@
 #include "trace/control.h"
 
 
-void trace_event_set_state_dynamic_init(TraceEvent *ev, bool state)
-{
-    trace_event_set_state_dynamic(ev, state);
-}
-
 void trace_event_set_state_dynamic(TraceEvent *ev, bool state)
 {
     bool state_pre;
diff --git a/trace/control-target.c b/trace/control-target.c
index 57ceac21084..24d9b7abbde 100644
--- a/trace/control-target.c
+++ b/trace/control-target.c
@@ -10,27 +10,6 @@
 #include "qemu/osdep.h"
 #include "trace/control.h"
 
-
-void trace_event_set_state_dynamic_init(TraceEvent *ev, bool state)
-{
-    bool state_pre;
-    assert(trace_event_get_state_static(ev));
-    /*
-     * We ignore the "vcpu" property here, since no vCPUs have been created
-     * yet. Then dstate can only be 1 or 0.
-     */
-    state_pre = *ev->dstate;
-    if (state_pre != state) {
-        if (state) {
-            trace_events_enabled_count++;
-            *ev->dstate = 1;
-        } else {
-            trace_events_enabled_count--;
-            *ev->dstate = 0;
-        }
-    }
-}
-
 void trace_event_set_state_dynamic(TraceEvent *ev, bool state)
 {
     assert(trace_event_get_state_static(ev));
-- 
2.56.0



  parent reply	other threads:[~2026-11-04 20:18 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 20:17 [PULL v2 00/25] Tracing patches Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 01/25] osdep: add 'ignore_value(x)' macro Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 02/25] trace: use 'ignore_value()' instead of a dummy variable Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 03/25] trace: fix handling of char** in UST backend Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 04/25] hw/xen: replace "long unsigned int" with "unsigned long " for dtrace Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 05/25] trace: block use of "long int" " Stefan Hajnoczi
2026-11-04 20:17 ` Stefan Hajnoczi [this message]
2026-11-04 20:17 ` [PULL v2 07/25] trace: remove obsolete references to vcpu property Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 08/25] trace: drop 'id' from TraceEvent struct when not required Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 09/25] trace: change "DSTATE" variables from uint16_t to uint8_t Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 10/25] trace: add testing of 'nop' trace backend Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 11/25] trace: don't emit TraceEvent structs when 'nop' backend is used Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 12/25] trace: add test of generation with all backends enabled Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 13/25] trace: remove redundant headers from simple trace backend code Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 14/25] trace: include probe name in Rust format strings Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 15/25] trace: add missing newline in ftrace Rust format string Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 16/25] trace: eliminate dupe trace_event_get_state_dynamic_by_id() calls Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 17/25] audio: remove mistaken use of trace_event_get_state() Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 18/25] hw/ppc: " Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 19/25] monitor: " Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 20/25] trace: include qemu_loglevel_mask(LOG_TRACE) in guard Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 21/25] target/hppa: use PRIx64 in trace-events Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 22/25] trace: remove "disable" property from trace files Stefan Hajnoczi
2026-11-04 20:17 ` [PULL v2 23/25] trace: stop tracking static disabled state Stefan Hajnoczi
2026-11-06 11:53   ` Markus Armbruster
2026-11-12 16:43     ` Daniel P. Berrangé
2026-11-04 20:18 ` [PULL v2 24/25] trace: remove parsing of "disable" event property Stefan Hajnoczi
2026-11-04 20:18 ` [PULL v2 25/25] trace: remove 'trace_event_get_state' wrapper Stefan Hajnoczi
2026-11-05 15:23 ` [PULL v2 00/25] Tracing patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261104201802.11556-7-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=anthony@xenproject.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=deller@gmx.de \
    --cc=eblake@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.