From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793826908; b=J+uuhsho+oEmFy/d/nUDEp1YHFua/MzSd5FRSGJ73VUqLLKVo8Pxl/jALV/ECbsfNebr 44GevOfLR4vtB8eIN+2UHvD8PQDNPvMbuIlGYuTtx5zZKWdX9c1WIfmJW8AUzk3wiHeV1 cmJtfb41PuAZvel/iRDzUlZGasyfmjeXl88/nSud9+wqRPAAzaz/fzYBhTQ5vFdvflPPq Klu4dYIqEXoJ3qsitATnwNnCW+brxsIXdjmfVpcrDpp9JZRvzDCKVed88je1CRfr6fDh7 RXF88RfpFTaYGeC/55FjHGPrfo36QSoMjfiSQjZ9sn1PCluneBN36+gnu7NEV1M5aUg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793826908; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=8820cd2C5ha2vYfcezcbkbGNa/IGVvWg5nkCKsJzl2c=; b=JgFqxJ34RQ37dQP+KUxS01popbf2qXH9S9PNDHs72539Fr7QUmLji+3mMNAvBpDryvdB UrNjnDrRmvcLRPpZVsOCi1VJJwmgREcU8s2HOpWSjf7eLP6XcWtpSSNjrUhHouBZC0gEL SFCbld2jN2yT7ZZORuLr7WwDR3hZvjb8L2ZUOul0vEDv+/lQwYIVKRnNfPk9dNICfpwVa XQOyk7544sCRwrTrX2Y2Tttfx3BResPNQoTOeqIhlJmzD6nGwJavWD0cF7cdy+WjiQW5W dy1O+QqxtpkTC5pAiAIv4Krsv13ak+JiJE+npX62w8NUz2IMygchHtdQAs++0Pe4gIQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=k5uZqJ0O; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED81D607267F; Wed, 4 Nov 2026 21:15:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=k5uZqJ0O Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C4E31F000C1; Wed, 4 Nov 2026 21:15:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793826907; bh=8820cd2C5ha2vYfcezcbkbGNa/IGVvWg5nkCKsJzl2c=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=k5uZqJ0Od6hqqSSIMDtcGMbwCVKfMlOB7Nsot5ANPrFrbdLBlAMN9DWgwvhCjggnk WUvBfk59y1grgso06Y3NyB+Ji0tImElaInJMCzdKIBLO+uia1Bkd7OY3rvhSI3bUGo 3xjN6vBMMjHBpNkT9FPOMe0TfAZsydqfhtUvBbNI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ijae Kim , Myeonghun Pak , Hans Verkuil Subject: [PATCH 7.3 078/547] media: cx88: Disable PCI device on MPEG initialization failure Date: Wed, 4 Nov 2026 16:04:22 -0500 Message-ID: <20261104211040.470032277@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261104211038.406938024@linuxfoundation.org> References: <20261104211038.406938024@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Myeonghun Pak commit 80494a83223bc972145c23890b083d20651512bd upstream. cx8802_init_common() enables the PCI device, then returns directly if DMA mask setup or IRQ registration fails. cx8802_probe() frees the device and drops the shared core reference without disabling PCI. Disable the PCI device on both post-enable failures. Preserve -EIO for a DMA mask failure and the original request_irq() error. Do not call the full fini helper because the IRQ was not successfully requested. The successful probe and normal removal paths are unchanged. These missing error-path disables are present in the initial Git import. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Assisted-by: OpenAI:GPT-5.6 Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/pci/cx88/cx88-mpeg.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) --- a/drivers/media/pci/cx88/cx88-mpeg.c +++ b/drivers/media/pci/cx88/cx88-mpeg.c @@ -392,7 +392,8 @@ static int cx8802_init_common(struct cx8 err = dma_set_mask(&dev->pci->dev, DMA_BIT_MASK(32)); if (err) { pr_err("Oops: no 32bit PCI DMA ???\n"); - return -EIO; + err = -EIO; + goto fail_disable_device; } dev->pci_rev = dev->pci->revision; @@ -413,13 +414,17 @@ static int cx8802_init_common(struct cx8 IRQF_SHARED, dev->core->name, dev); if (err < 0) { pr_err("can't get IRQ %d\n", dev->pci->irq); - return err; + goto fail_disable_device; } cx_set(MO_PCI_INTMSK, core->pci_irqmask); /* everything worked */ pci_set_drvdata(dev->pci, dev); return 0; + +fail_disable_device: + pci_disable_device(dev->pci); + return err; } static void cx8802_fini_common(struct cx8802_dev *dev)