From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793826979; b=CJvPpCOsMBmT1HGiaw1NE1hzQJK+3eRyMKvK+R3hwe6acjZfoc4/SRx4pZAUOjZ4Yqm7 SiF7VNcknqgck1M0ckfLUXUUoudjfi96Qcxw5fWei/gNKxvAI0Rl7oyteyzP9+qCzCXZM hDveTghqyvAe6NfHfyTwm9nliOMuTKTp6yqOKWMkaVlQLGc7zlN2Ak1qez3NM10xSBo5w W/cXINUhqt2+Sgpfy08fbZftPsbKwX0FX5pEf87BD8BmEQuiuwh0lJyNqE7KlaXuH30bp 4iyst8BzqNxgj2EBVOIaCHWL6nneAR1GRUW4QipjebbqDycSObNU7yHCPOXrCP8uoNQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793826979; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=X1teyqlWFzY5/FlfoeE+el87K9v2RSEIEb1/XuHVrqE=; b=SnXTwZ1xfvRZwx2qG5f/LvremNq6LRmYhvP5UxEUXtlO67xxbr2UWJfsQCqUFwHCV0OY PI97Fcgm5OsAWEQzLVb9NsE5355HkqugPMrXCV9iVsxtcAxULG+w4O5cYrek3RTo0mPhw HuKqw1RqKJZlJC0U4uXI1tSgbVxqOLIkQcqGULhmIrkSCkkggu9LeauWgXedW2ZWUupu7 1BBytd/36AJqqZ2nfXkoP4zPLATmtUToZkj2uJhKyvghlWFVNBMJQfBoy69PQL6kMIn+Q JyfWF4k8MLRMqX8LikVe/h1PdXmK335dpo69dsjGUqQNYUTSewRoaA2Vh+6OTtHePGA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=lt3Vp0lO; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B0D607352D; Wed, 4 Nov 2026 21:16:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=lt3Vp0lO Received: by smtp.kernel.org (Postfix) with ESMTPSA id 818C71F000C1; Wed, 4 Nov 2026 21:16:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793826978; bh=X1teyqlWFzY5/FlfoeE+el87K9v2RSEIEb1/XuHVrqE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lt3Vp0lOiXdbijXBalcoxGkjkgD/jsIUtggR0hXL2blmAlv/rQ8N6y9mdqjRMBBFd OQx0TycdeMj69Dpjhc43jNdJwYY1+FwWpxUUgOZXbb8M2/KIQ+ByTVKQWqCQbXlthi O+LLyB3zK2HajYRTIOVXYwW5x8D6bwmwnrEgF8Jg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, AutonomousCodeSecurity@microsoft.com, "Cen Zhang (Microsoft)" , Namjae Jeon Subject: [PATCH 7.3 121/547] ksmbd: fix parent dentry lifetime in directory enumeration Date: Wed, 4 Nov 2026 16:05:05 -0500 Message-ID: <20261104211041.632967088@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261104211038.406938024@linuxfoundation.org> References: <20261104211038.406938024@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cen Zhang (Microsoft) commit 171df27077fb49b4af2c53ad2cedcd0e39664fe8 upstream. ksmbd_populate_dot_dotdot_entries() builds the ".." entry from the open directory's d_parent and passes that pointer to ksmbd_vfs_fill_dentry_attrs() without taking a reference. That pointer is only valid while the directory stays under this parent. If a concurrent rename moves the directory elsewhere, the old parent loses its last reference; a following rmdir then turns it into a negative dentry with d_inode cleared, and after the RCU grace period the dentry itself is freed. The worker still holds the raw pointer and dereferences d_inode through vfs_getattr() and vfs_getxattr(). A remote SMB client, authenticated or guest, triggers this by listing a directory while that directory is moved under a new parent and the old parent is deleted. It can be done by the client itself with write access or by other concurrent writers, triggering null-ptr-deref and slab-use-after-free on a KASAN build. KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] Workqueue: ksmbd-io handle_ksmbd_work RIP: 0010:xattr_permission+0x9d/0x160 Call Trace: vfs_getxattr+0x9c/0x1b0 ksmbd_vfs_getxattr+0x82/0x100 ksmbd_vfs_get_dos_attrib_xattr+0x7f/0x130 ksmbd_vfs_fill_dentry_attrs+0x435/0x650 ksmbd_populate_dot_dotdot_entries+0x25e/0x630 smb2_query_dir+0xcf9/0x1a20 handle_ksmbd_work+0x5f1/0x1c80 process_one_work+0x90b/0x19d0 Fix by using the dentry reference counting APIs: take the parent with dget_parent(), take a matching dget() on ".", and dput() the dentry once ksmbd_vfs_fill_dentry_attrs() has returned or the pattern does not match. Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3") Cc: stable@vger.kernel.org Cc: AutonomousCodeSecurity@microsoft.com Signed-off-by: Cen Zhang (Microsoft) Signed-off-by: Namjae Jeon Signed-off-by: Greg Kroah-Hartman --- fs/smb/server/smb_common.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/fs/smb/server/smb_common.c +++ b/fs/smb/server/smb_common.c @@ -478,16 +478,17 @@ int ksmbd_populate_dot_dotdot_entries(st if (i == 0) { d_info->name = "."; d_info->name_len = 1; - dentry = dir->filp->f_path.dentry; + dentry = dget(dir->filp->f_path.dentry); } else { d_info->name = ".."; d_info->name_len = 2; - dentry = dir->filp->f_path.dentry->d_parent; + dentry = dget_parent(dir->filp->f_path.dentry); } if (!match_pattern(d_info->name, d_info->name_len, search_pattern)) { dir->dot_dotdot[i] = 1; + dput(dentry); continue; } @@ -496,6 +497,7 @@ int ksmbd_populate_dot_dotdot_entries(st idmap, dentry, &ksmbd_kstat); + dput(dentry); if (rc) break;