From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793827050; b=zdfrvo2iHU4lkhF/RAG5MJqS5u0L32Z2VSqGhm5T+8qwjAQ6E8Q16P0+K4k31tXIfvb2 JmNDAY2D3ggLpHeicr6277SgB+gPKqNmmzxNpTZywQQPf1xg8kVYqYLOKHDMUyCXXV3fM ccgI85CdgBJwnwHtMNmzGCYLw9sTWEBmwRfmvs2D1cN76eIVzMbS2EXD22L7Eom4v4QgF MJiU8l1FnwXdrj+H9ewZM+jexCE65ob3dh1Ev4nqGlI9Nudz8A5lz6r16CgQZsiIyQy49 I5h97sQ5gZ2NmgDgruWUA2QcEb66C0CG99W/qEC+VdA1kCUfugzGEXL3egubK0aVw+Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793827050; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=7bOvXNEd7X1CxQ4VXR8ZXOd3T1K2EU+8giPbZDrR6zg=; b=30Bxj+ZHM+roRSLnpB4Ee8J5/HLk1BhybQ/b9WJzdUnpBRfnof80zFgP3RAJYLSMinYD ho+Bqyka3oMICmMJPYJlFHCMk8P8W19kXpAPszmGthyol+H9ftDOvSA1Ms3i2tHxbUqOg Yi/3LcO4Gsh9eHQT4owvr3crB0ONL4B3FB4SaQuv2W5g+n+T0t3ugYbztjyCRTFBhDj0t O/uceA1ApPcs64fObBp/iX1ue5g1ofNlwRxZDpcYkI3vgXMy6EhFToyHNPA8DTwZO3Osf 8XN1CmpP6eQKe0bgxpvKJnXpC78hGQw8oF1tPxX/3k/b7nuG2m1sEafSzo1gTIGPP1w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=NXzu958G; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E46F606A863; Wed, 4 Nov 2026 21:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=NXzu958G Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D5D41F000C1; Wed, 4 Nov 2026 21:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793827049; bh=7bOvXNEd7X1CxQ4VXR8ZXOd3T1K2EU+8giPbZDrR6zg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=NXzu958GcRQzYVVyGXvE9bMkkatGS6vx+AQBT9cpx2UdyVU7UKMI5nj3eZpO6ELlt s7xv5hOUysyqRoyu7thXLxpzsTC3qJr0/o3ScRF+xddDZWGOJwRavNtXGGysppolb2 9jRqG0/Ibe0JVT2KKNgCiMtjp1GOvt1l0cuRO94I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Josef Bacik , "David Hildenbrand (Arm)" , Andrew Morton , "Lorenzo Stoakes (ARM)" , Muchun Song , Lance Yang , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Oscar Salvador , Miaohe Lin , Naoya Horiguchi , Adam Litke , Mel Gorman , Rik van Riel , Peter Xu , Kiryl Shutsemau , Mike Rapoport Subject: [PATCH 7.3 164/547] mm/hugetlb: fix use-after-free of a new anon folio Date: Wed, 4 Nov 2026 16:05:48 -0500 Message-ID: <20261104211042.813226087@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261104211038.406938024@linuxfoundation.org> References: <20261104211038.406938024@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Josef Bacik commit 824cc56bf43c714319992bad3558803cac6e77c0 upstream. For a fault in a private mapping with nothing in the page cache, hugetlb_no_page() allocates a folio, locks it and maps it. The folio has one reference, which belongs to the page table entry from then on. After dropping the page table lock the function still sets the migratable flag of the folio and unlocks it. Whoever zaps the entry in between frees the folio. The fault holds the fault mutex and the lock of the vma. MADV_DONTNEED and the first unmap of a hole punch, hugetlb_vmdelete_list(), do not take the fault mutex, and a private vma only has a lock if it owns a reservation map: not with MAP_NORESERVE, and not in the child after fork(). Then the flag is set in, and folio_unlock() is called on, a folio that is free or has a new owner. A surplus page goes back to the page allocator while it is locked: BUG: Bad page state in process init pfn:108e00 flags: 0x200000000000059(locked|uptodate|dirty|head|node=0|zone=2) page dumped because: PAGE_FLAGS_CHECK_AT_FREE flag(s) set A page of the pool can be given to the next user, of any file, who locks it and loses the lock to the late folio_unlock(): kernel BUG at mm/filemap.c:1532! hugetlb_no_page+0x111b/0x23e0 hugetlb_fault+0x3a9/0x14a0 An unprivileged process is enough: threads that write to a MAP_PRIVATE | MAP_NORESERVE hugetlb mapping, threads that call MADV_DONTNEED on it, and one that takes the freed pages for another file. Until commit 3a47c54f09c4 ("hugetlbfs: revert use i_mmap_rwsem for more pmd sharing synchronization") the fault held i_mmap_rwsem for reading, which everybody who zaps takes for writing. The lock that commit bf4916922c60 ("hugetlbfs: extend hugetlb_vma_lock to private VMAs") gave to private vmas closed the window again, but only for those with a reservation map. Be done with the folio before the page table lock is dropped, as hugetlb_wp() is with its copy. The function already unlocks page cache folios under that lock. Original fix generated by an LLM and sent in private by Josef. [david@kernel.org: simplify+move comment] Link: https://lore.kernel.org/20261015-urgent_fixes-v1-2-42796911043b@kernel.org Fixes: 3a47c54f09c4 ("hugetlbfs: revert use i_mmap_rwsem for more pmd sharing synchronization") Signed-off-by: Josef Bacik Signed-off-by: David Hildenbrand (Arm) Signed-off-by: Andrew Morton Reviewed-by: Lorenzo Stoakes (ARM) Acked-by: Muchun Song Reviewed-by: Lance Yang Cc: Liam R. Howlett Cc: Vlastimil Babka Cc: Jann Horn Cc: Pedro Falcato Cc: Oscar Salvador Cc: Miaohe Lin Cc: Naoya Horiguchi Cc: Adam Litke Cc: Mel Gorman Cc: Rik van Riel Cc: Peter Xu Cc: Kiryl Shutsemau Cc: Mike Rapoport Cc: Signed-off-by: Greg Kroah-Hartman --- mm/hugetlb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -5949,8 +5949,6 @@ static vm_fault_t hugetlb_no_page(struct ret = hugetlb_wp(vmf); } - spin_unlock(vmf->ptl); - /* * Only set hugetlb_migratable in newly allocated pages. Existing pages * found in the pagecache may not have hugetlb_migratable if they have @@ -5961,6 +5959,12 @@ static vm_fault_t hugetlb_no_page(struct if (folio_locked) folio_unlock(folio); + + /* + * Hold the PTL until we're done with the folio: the page table owns the + * folio reference now. + */ + spin_unlock(vmf->ptl); out: hugetlb_vma_unlock_read(vma);