From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793829162; b=Vcsgk/1u/DxhYahyi04BhkiH9gIG8bqDXndPY5Umc/dSFtLUNpGGMJrxV7aoFFnkUNQb XwCYOkAiMlP43Ida0PnQsYgA3qX6NoZwiP6OWzng5uT4M/W8ytog4ZrsZsqCCIsZ54vE5 +W1afzOV+jJb5qrwjQv0qY5UyimAx+xw4uZmsI1X6lujhgD7jpsAhlkR+z+E8T6WI2j0V B2XQh/LWi7/9TebdmeNxmWcsT9eUJvi2kKW2tWxY1Ns1RQsDO0Y3S3BgdiU/Ezq+o8AHY +7Kk0Xvzi4fR2js3DSX3VDsoOLemR2vzdNiX0zufg2md4fJmXMkUC7VTKMsyIwXwHpQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793829162; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=rl0YmEVlaSX6HMvuar2htEC3brlsNWlUWNzxCUg42Ro=; b=BBVNEF15n4CnoxJxGpPDtDE6eYABNfIpzwUAGLFPX9yRreD2U1EtzpkU6+ENpsfhlJQB 9n4fZXiTU5HanFM2s39WLTdHU5QgkxGHsUSnRFhPurD2mxX2TA8Iyeiv5wDkWH8H+j7kG gilyl+RM3d536Ors2rq14m7ngvbfU5E7MBWtxL/TcrRnEXnsOR7LM6m9GvRvv+xMl+45m hroRhjAsExRwEdL9trX6twkyko5+P1IcufPEZXp2v0jejQqBhC+mgYwOUpqfMS9/6qRqr lhwp2MULMc2edA0Tn/aACqydFIe9DD1GCUsJ3Dnxds7EbtZmUbuBVM79dabWy+wEvyg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=EqPzSgPK; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4C23607031A; Wed, 4 Nov 2026 21:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=EqPzSgPK Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4727A1F00919; Wed, 4 Nov 2026 21:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793829161; bh=rl0YmEVlaSX6HMvuar2htEC3brlsNWlUWNzxCUg42Ro=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EqPzSgPK5n+S9trM5NEIb815dpp4kntuZFSbV0YYhjpDR6x5c8OGBuTm6OrOkg2UD pydFu13pfDd2PSHHpjsSoC979n/9x4nFNuUuF34DcSmyIjI3IkK3gzvHPFdDTGm4yj fJj+XUhYOvScDCN8N7Zyu1gsp/ockowduaU4OCWU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andrej Scek , Basavaraj Natikar , Jiri Kosina Subject: [PATCH 7.3 485/547] HID: amd_sfh: Remove unsupported motion-state field from accelerometer report Date: Wed, 4 Nov 2026 16:11:09 -0500 Message-ID: <20261104211052.158837625@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261104211038.406938024@linuxfoundation.org> References: <20261104211038.406938024@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Basavaraj Natikar commit 6ff86122906357687735dd379c6279e3b2fa26af upstream. The accelerometer HID report descriptor declares a trailing motion-state field (usage 0x0451), but the Sensor Fusion Hub never reports this data, so each accelerometer input report is one byte shorter than the descriptor advertises. This was previously harmless because hid-core zero-padded short reports. Since commit 0a3fe972a7cb ("HID: core: Mitigate potential OOB by removing bogus memset()") such reports are rejected instead: hid-sensor-hub 0020:1022:0001.0003: Event data for report 1 was too short (15 vs 14) As a result the accelerometer input events are dropped and screen auto-rotation stops working on AMD SFH systems. Remove the motion-state field from the accelerometer report descriptor and drop the unused in_accel_shake_detection member, so the descriptor matches the report actually provided by the hardware. Fixes: 1434f9fc0e47 ("SFH: Create HID report to Enable support of AMD sensor fusion Hub (SFH)") Reported-by: Andrej Scek Closes: https://lore.kernel.org/linux-input/CADrS85612m-Hh-G4BJmOhy-y6r3Ni3kD8_GM-2QRBeWWEEZWuA@mail.gmail.com/ Cc: stable@vger.kernel.org Signed-off-by: Basavaraj Natikar Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.h | 2 -- drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h | 7 ------- 2 files changed, 9 deletions(-) --- a/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.h +++ b/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.h @@ -48,8 +48,6 @@ struct accel3_input_report { int in_accel_x_value; int in_accel_y_value; int in_accel_z_value; - /* include if required to support the "shake" event */ - u8 in_accel_shake_detection; } __packed; struct gyro_feature_report { --- a/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h +++ b/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h @@ -169,13 +169,6 @@ static const u8 accel3_report_descriptor 0x95, 1, /* HID report count (1) */ 0x55, 0x0E, /* HID unit exponent(0x0E) */ 0X81, 0x02, /* HID Input (Data_Arr_Abs) */ - -0x0A, 0x51, 0x04, /* HID usage sensor data motion state */ -0x15, 0, /* HID logical Min_8(0) False = Still*/ -0x25, 1, /* HID logical Min_8(1) True = In motion */ -0x75, 8, /* HID report size(8) */ -0x95, 1, /* HID report count (1) */ -0X81, 0x02, /* HID Input (Data_Arr_Abs) */ 0xC0 /* HID end collection */ };