From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793829246; b=OTEADAIceNNeTGcVgbYPg7PDkQnYZ5CZwA+VpGftkDu8Si6cbzrIXFg1ULWO9NdojqqP aMcdqkjNC8fvQlJIZLYHhYiaGQyO6DaBsEy/QYM3CPG8HdzrRZ07hgyUFFO4HZW4yseX/ CYFj4gv0SxH5sfrKmRkeSBWG8O/v73++vQd3P0GtvZPYitLhl667KdoZ6gpgrZnqFSULL rkDKftQlYmR9OmzMGdDebpBBOAq3aRohG+/VBwnKUAELePlmmSzpypjHiCKjhCaeW10/e fCRLUyaJmdXW8T8YfS/9asyfBS0UTASpmxory+1Q7VJ+gOQ5zxd7cxH3g50UtnGBOJQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793829246; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=SNCV45zhGEICJbIDxyk+HgRE6ndD60cIu5EaNalasjc=; b=I/gQKa3LEvuznsbl+JEwEBPHagbDRbQC7OJcLz5AKdL9vEL8rBhPtHAXHw4WcRPyrBZC nqhdLR57X/0mzSszbRlcB3xcn+UnBtovazdxaHBOzMiA2idybeDKNRqg/x2DaUzTkMkXL KbXgdCX1tsEzMrjfJDKeFyXfBufAMWfLZP9uJf4CZ3ePEf9BI2rN+ETZ7H/9TtSjbuG4O 0Wjudp1GJRrYyl9UPowqpenI8I981SaDyJrk5zg/5UWwoHl3ZW1LE1zuidhHvvMAK8DrC 8dTssCzm36/4Rw+MPtdIdhyK+sK23ctQFPN8fOvLBJEn443bOD9BhJq0VRdhTrXF1mA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=DJwlQFtc; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AF46607031F; Wed, 4 Nov 2026 21:54:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=DJwlQFtc Received: by smtp.kernel.org (Postfix) with ESMTPSA id C32721F000C1; Wed, 4 Nov 2026 21:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793829246; bh=SNCV45zhGEICJbIDxyk+HgRE6ndD60cIu5EaNalasjc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=DJwlQFtc/CGc/EP+mgysaucCo3RyAQNS1376A97aS/6Qa+kx1brd634R4WUUcN7mL 3EJPkSuJJ/bGAw68UH1EjSO+W4wehgCSJ0mvpGmvESrGZS3L8bp0v4YVbPxMEw0Sg6 NHv3BqsdOAFCHlrIpQqcNAi6dvWQ448OA5Ojv3qw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, ChenXiaoSong , Henry Hu , Namjae Jeon , Sasha Levin Subject: [PATCH 7.3 540/547] ksmbd: fix invalid pointer dereference when get_inode_acl() fails Date: Wed, 4 Nov 2026 16:12:04 -0500 Message-ID: <20261104211053.749464877@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261104211038.406938024@linuxfoundation.org> References: <20261104211038.406938024@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Henry Hu [ Upstream commit 19d180c7baab7126af5848ed87d5f7b5add0cef2 ] When get_inode_acl() fails, it returns an ERR_PTR(), but ksmbd_acls_fattr() stored that pointer in smb_fattr without checking for errors. Later callers then passed the error pointer to security descriptor helpers or posix_acl_release(), resulting in an invalid pointer dereference. This was reproduced on an XFS-backed share when xfs_get_acl() returned ERR_PTR(-ENOMEM). Querying the SMB ACL from a CIFS client triggered the crash: BUG: unable to handle page fault for address: fffffffffffffff8 RIP: smb_acl_sec_desc_scratch_len+0x58/0x90 [ksmbd] Call Trace: smb2_query_info+0x40d/0x17c0 [ksmbd] handle_ksmbd_work+0x1ca/0x770 [ksmbd] Fix this by checking the return values from get_inode_acl() in ksmbd_acls_fattr(). Treat -EOPNOTSUPP as indicating that no ACL is available, and propagate all other errors to the callers. Update smb2_open() and smb2_get_info_sec() to handle these errors. Cc: stable@vger.kernel.org Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3") Assisted-by: Codex:gpt-5.6-sol Reviewed-by: ChenXiaoSong Signed-off-by: Henry Hu Signed-off-by: Namjae Jeon [ sashal: Retained the non-const struct mnt_idmap * parameter in ksmbd_acls_fattr() to match the existing UID/GID mapping helpers. ] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- fs/smb/server/smb2pdu.c | 42 ++++++++++++++++++++++++++++++++++-------- 1 file changed, 34 insertions(+), 8 deletions(-) --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -3694,10 +3694,11 @@ static int smb2_create_sd_buffer(struct le32_to_cpu(sd_buf->ccontext.DataLength), true, false); } -static void ksmbd_acls_fattr(struct smb_fattr *fattr, - struct mnt_idmap *idmap, - struct inode *inode) +static int ksmbd_acls_fattr(struct smb_fattr *fattr, + struct mnt_idmap *idmap, + struct inode *inode) { + struct posix_acl *acl; vfsuid_t vfsuid = i_uid_into_vfsuid(idmap, inode); vfsgid_t vfsgid = i_gid_into_vfsgid(idmap, inode); @@ -3708,10 +3709,28 @@ static void ksmbd_acls_fattr(struct smb_ fattr->cf_dacls = NULL; if (IS_ENABLED(CONFIG_FS_POSIX_ACL)) { - fattr->cf_acls = get_inode_acl(inode, ACL_TYPE_ACCESS); - if (S_ISDIR(inode->i_mode)) - fattr->cf_dacls = get_inode_acl(inode, ACL_TYPE_DEFAULT); + acl = get_inode_acl(inode, ACL_TYPE_ACCESS); + if (IS_ERR(acl)) { + if (acl != ERR_PTR(-EOPNOTSUPP)) + return PTR_ERR(acl); + acl = NULL; + } + fattr->cf_acls = acl; + + if (S_ISDIR(inode->i_mode)) { + acl = get_inode_acl(inode, ACL_TYPE_DEFAULT); + if (IS_ERR(acl)) { + if (acl != ERR_PTR(-EOPNOTSUPP)) { + posix_acl_release(fattr->cf_acls); + return PTR_ERR(acl); + } + acl = NULL; + } + fattr->cf_dacls = acl; + } } + + return 0; } enum { @@ -4931,7 +4950,10 @@ resolve_path: int pntsd_size; size_t scratch_len; - ksmbd_acls_fattr(&fattr, idmap, inode); + rc = ksmbd_acls_fattr(&fattr, idmap, inode); + if (rc) + goto err_out; + scratch_len = smb_acl_sec_desc_scratch_len(&fattr, NULL, 0, OWNER_SECINFO | GROUP_SECINFO | @@ -7793,7 +7815,11 @@ static int smb2_get_info_sec(struct ksmb idmap = file_mnt_idmap(fp->filp); inode = file_inode(fp->filp); - ksmbd_acls_fattr(&fattr, idmap, inode); + rc = ksmbd_acls_fattr(&fattr, idmap, inode); + if (rc) { + ksmbd_fd_put(work, fp); + return rc; + } if (test_share_config_flag(work->tcon->share_conf, KSMBD_SHARE_FLAG_ACL_XATTR))