From: Mark Brown <broonie@kernel.org>
To: Simon Trimmer <simont@opensource.cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <david@davidgow.net>, Rae Moar <raemoar63@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Baokun Li <libaokun@linux.alibaba.com>, Jan Kara <jack@suse.cz>,
Ojaswin Mujoo <ojaswin@linux.ibm.com>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Zhang Yi <yi.zhang@huawei.com>,
David Rhodes <david.rhodes@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-doc@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-sound@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: [PATCH v2 4/9] firmware: cs_dsp: Give the control read/write KUnit cases distinct names
Date: Thu, 05 Nov 2026 16:00:31 +0000 [thread overview]
Message-ID: <20261105-kunit-param-names-v2-4-765b3d5275d2@kernel.org> (raw)
In-Reply-To: <20261105-kunit-param-names-v2-0-765b3d5275d2@kernel.org>
The cs_dsp_ctl_rw suites run cs_dsp_ctl_write_running() and
cs_dsp_ctl_read_volatile_running() against several sets of parameters
by listing each function several times with KUNIT_CASE_PARAM(), which
names the case after the function. The resulting cases all share a
name, so they cannot be told apart in the results.
Use KUNIT_CASE_PARAM_UNIQUE() for these entries so that each case is
also named for the parameter generator it is run with, for example
cs_dsp_ctl_write_running-all_pop_varying_len_gen_params.
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
.../firmware/cirrus/test/cs_dsp_test_control_rw.c | 50 +++++++++++-----------
1 file changed, 26 insertions(+), 24 deletions(-)
diff --git a/drivers/firmware/cirrus/test/cs_dsp_test_control_rw.c b/drivers/firmware/cirrus/test/cs_dsp_test_control_rw.c
index d800f163b099..085a1cb92912 100644
--- a/drivers/firmware/cirrus/test/cs_dsp_test_control_rw.c
+++ b/drivers/firmware/cirrus/test/cs_dsp_test_control_rw.c
@@ -2483,19 +2483,20 @@ KUNIT_ARRAY_PARAM(all_pop_volatile_writeable_flags,
cs_dsp_ctl_all_param_desc);
static struct kunit_case cs_dsp_ctl_rw_test_cases_adsp[] = {
- KUNIT_CASE_PARAM(cs_dsp_ctl_write_running, all_pop_varying_len_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_write_running, all_pop_varying_offset_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_write_running, all_pop_varying_xy_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_write_running, all_pop_z_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_write_running, all_pop_varying_alg_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_write_running, all_pop_writeable_flags_gen_params),
-
- KUNIT_CASE_PARAM(cs_dsp_ctl_read_volatile_running, all_pop_varying_len_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_read_volatile_running, all_pop_varying_offset_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_read_volatile_running, all_pop_varying_xy_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_read_volatile_running, all_pop_z_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_read_volatile_running,
- all_pop_volatile_readable_flags_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_write_running, all_pop_varying_len_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_write_running, all_pop_varying_offset_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_write_running, all_pop_varying_xy_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_write_running, all_pop_z_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_write_running, all_pop_varying_alg_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_write_running, all_pop_writeable_flags_gen_params),
+
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_read_volatile_running, all_pop_varying_len_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_read_volatile_running,
+ all_pop_varying_offset_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_read_volatile_running, all_pop_varying_xy_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_read_volatile_running, all_pop_z_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_read_volatile_running,
+ all_pop_volatile_readable_flags_gen_params),
KUNIT_CASE_PARAM(cs_dsp_ctl_read_volatile_not_started,
all_pop_volatile_readable_flags_gen_params),
@@ -2559,17 +2560,18 @@ static struct kunit_case cs_dsp_ctl_rw_test_cases_adsp[] = {
};
static struct kunit_case cs_dsp_ctl_rw_test_cases_halo[] = {
- KUNIT_CASE_PARAM(cs_dsp_ctl_write_running, all_pop_varying_len_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_write_running, all_pop_varying_offset_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_write_running, all_pop_varying_xy_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_write_running, all_pop_varying_alg_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_write_running, all_pop_writeable_flags_gen_params),
-
- KUNIT_CASE_PARAM(cs_dsp_ctl_read_volatile_running, all_pop_varying_len_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_read_volatile_running, all_pop_varying_offset_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_read_volatile_running, all_pop_varying_xy_gen_params),
- KUNIT_CASE_PARAM(cs_dsp_ctl_read_volatile_running,
- all_pop_volatile_readable_flags_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_write_running, all_pop_varying_len_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_write_running, all_pop_varying_offset_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_write_running, all_pop_varying_xy_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_write_running, all_pop_varying_alg_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_write_running, all_pop_writeable_flags_gen_params),
+
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_read_volatile_running, all_pop_varying_len_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_read_volatile_running,
+ all_pop_varying_offset_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_read_volatile_running, all_pop_varying_xy_gen_params),
+ KUNIT_CASE_PARAM_UNIQUE(cs_dsp_ctl_read_volatile_running,
+ all_pop_volatile_readable_flags_gen_params),
KUNIT_CASE_PARAM(cs_dsp_ctl_read_volatile_not_started,
all_pop_volatile_readable_flags_gen_params),
--
2.47.3
next prev parent reply other threads:[~2026-11-05 16:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 16:00 [PATCH v2 0/9] kunit: Add KUNIT_CASE_PARAM_UNIQUE() and KUNIT_CASE_PARAM_WITH_INIT_UNIQUE() Mark Brown
2026-11-05 16:00 ` [PATCH v2 1/9] firmware: cs_dsp: Run the wmfw payload error tests with invalid block types Mark Brown
2026-11-06 5:27 ` sashiko-bot
2026-11-05 16:00 ` [PATCH v2 2/9] kunit: Add KUNIT_CASE_PARAM_UNIQUE() and KUNIT_CASE_PARAM_WITH_INIT_UNIQUE() Mark Brown
2026-11-06 5:30 ` sashiko-bot
2026-11-05 16:00 ` [PATCH v2 3/9] ext4: Give the extents KUnit cases distinct names Mark Brown
2026-11-06 5:32 ` sashiko-bot
2026-11-05 16:00 ` Mark Brown [this message]
2026-11-06 5:33 ` [PATCH v2 4/9] firmware: cs_dsp: Give the control read/write " sashiko-bot
2026-11-05 16:00 ` [PATCH v2 5/9] firmware: cs_dsp: Give the control cache " Mark Brown
2026-11-06 5:37 ` sashiko-bot
2026-11-05 16:00 ` [PATCH v2 6/9] firmware: cs_dsp: Give the wmfw block error " Mark Brown
2026-11-06 5:38 ` sashiko-bot
2026-11-05 16:00 ` [PATCH v2 7/9] firmware: cs_dsp: Give the bin file " Mark Brown
2026-11-06 5:39 ` sashiko-bot
2026-11-05 16:00 ` [PATCH v2 8/9] ASoC: cs35l56: Give the speaker ID pad config " Mark Brown
2026-11-06 5:41 ` sashiko-bot
2026-11-05 16:00 ` [PATCH v2 9/9] ASoC: wm_adsp: Give the firmware search order " Mark Brown
2026-11-06 5:42 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105-kunit-param-names-v2-4-765b3d5275d2@kernel.org \
--to=broonie@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=brendan.higgins@linux.dev \
--cc=ckeepax@opensource.cirrus.com \
--cc=corbet@lwn.net \
--cc=david.rhodes@cirrus.com \
--cc=david@davidgow.net \
--cc=jack@suse.cz \
--cc=kunit-dev@googlegroups.com \
--cc=lgirdwood@gmail.com \
--cc=libaokun@linux.alibaba.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=raemoar63@gmail.com \
--cc=rdunlap@infradead.org \
--cc=rf@opensource.cirrus.com \
--cc=ritesh.list@gmail.com \
--cc=simont@opensource.cirrus.com \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.com \
--cc=tytso@mit.edu \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.