From: David Laight <david.laight.linux@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Daniel West <daniel.west.dev@gmail.com>,
vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
elder@kernel.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: Add newlines to sysfs output
Date: Thu, 5 Nov 2026 09:12:34 +0000 [thread overview]
Message-ID: <20261105091234.008c0c2f@pumpkin> (raw)
In-Reply-To: <2026102808-stunning-headgear-4355@gregkh>
On Wed, 28 Oct 2026 05:19:45 +0100
Greg KH <gregkh@linuxfoundation.org> wrote:
...
> > WARNING: return sysfs_emit(...) formats should include a terminating newline
>
> Please read the archives for why this warning is ok to ignore here.
I was contemplating a patch to the sysfs code add missing '\n' and
also remove trailing ", ;" that come from generating lists.
It would make a lot of code a lot simpler.
I found one place that puts binary data into the buffer (horrid).
(I have a plan for that.)
So why is this one special, there is nothing in the commit messages.
David
prev parent reply other threads:[~2026-11-05 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 22:31 [PATCH] staging: greybus: Add newlines to sysfs output Daniel West
2026-10-28 4:19 ` Greg KH
2026-11-02 16:45 ` Daniel West
2026-11-05 9:12 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105091234.008c0c2f@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=daniel.west.dev@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.