All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
To: qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
	"Kostiantyn Kostiuk" <kkostiuk@redhat.com>,
	"Michael Roth" <michael.roth@amd.com>
Subject: [PATCH v2 17/17] qga/vss-win32: Replace deprecated sprintf() by StrCatBuffA()
Date: Thu,  5 Nov 2026 13:52:02 +0100	[thread overview]
Message-ID: <20261105125203.40320-18-philmd@oss.qualcomm.com> (raw)
In-Reply-To: <20261105125203.40320-1-philmd@oss.qualcomm.com>

Formatting is not necessary, replace the deprecated
sprintf() by StrCpyNA() and StrCatBuffA() calls.

Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
---
 qga/vss-win32/install.cpp | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
index df00588c923a..1a3d5cbf75d5 100644
--- a/qga/vss-win32/install.cpp
+++ b/qga/vss-win32/install.cpp
@@ -562,7 +562,8 @@ STDAPI DllRegisterServer(void)
 
     /* Add this module to registry */
 
-    sprintf(key, "CLSID\\%s", g_szClsid);
+    StrCpyNA(key, "CLSID\\", sizeof(key));
+    StrCatBuffA(key, g_szClsid, sizeof(key));
     if (!CreateRegistryKey(key, NULL, g_szClsid)) {
         goto out;
     }
@@ -572,7 +573,9 @@ STDAPI DllRegisterServer(void)
         goto out;
     }
 
-    sprintf(key, "CLSID\\%s\\InprocServer32", g_szClsid);
+    StrCpyNA(key, "CLSID\\", sizeof(key));
+    StrCatBuffA(key, g_szClsid, sizeof(key));
+    StrCatBuffA(key, "\\InprocServer32", sizeof(key));
     if (!CreateRegistryKey(key, NULL, dllPath)) {
         goto out;
     }
@@ -581,7 +584,9 @@ STDAPI DllRegisterServer(void)
         goto out;
     }
 
-    sprintf(key, "CLSID\\%s\\ProgID", g_szClsid);
+    StrCpyNA(key, "CLSID\\", sizeof(key));
+    StrCatBuffA(key, g_szClsid, sizeof(key));
+    StrCatBuffA(key, "\\ProgID", sizeof(key));
     if (!CreateRegistryKey(key, NULL, g_szProgid)) {
         goto out;
     }
@@ -590,7 +595,8 @@ STDAPI DllRegisterServer(void)
         goto out;
     }
 
-    sprintf(key, "%s\\CLSID", g_szProgid);
+    StrCpyNA(key, g_szProgid, sizeof(key));
+    StrCatBuffA(key, "\\CLSID", sizeof(key));
     if (!CreateRegistryKey(key, NULL, g_szClsid)) {
         goto out;
     }
@@ -651,7 +657,8 @@ STDAPI DllUnregisterServer(void)
         errmsg(hr, "CoCreateInstance(VSSCoordinator) failed");
     }
 
-    sprintf(key, "CLSID\\%s", g_szClsid);
+    StrCpyNA(key, "CLSID\\", sizeof(key));
+    StrCatBuffA(key, g_szClsid, sizeof(key));
     SHDeleteKey(HKEY_CLASSES_ROOT, key);
     SHDeleteKey(HKEY_CLASSES_ROOT, g_szProgid);
 
-- 
2.55.0



  parent reply	other threads:[~2026-11-05 12:58 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 12:51 [PATCH v2 00/17] buildsys: Replace some deprecated sprintf() Philippe Mathieu-Daudé
2026-11-05 12:51 ` [PATCH v2 01/17] tests/qtest: Use qemu_hexdump_to_buffer() in qtest_memwrite() Philippe Mathieu-Daudé
2026-11-06 16:02   ` Peter Maydell
2026-11-05 12:51 ` [PATCH v2 02/17] tests/qtest/npcm7xx: Replace deprecated sprintf() with g_strdup_printf() Philippe Mathieu-Daudé
2026-11-05 16:02   ` Alex Bennée
2026-11-06 18:52     ` Hao Wu
2026-11-05 12:51 ` [PATCH v2 03/17] tests/unit/qobject: " Philippe Mathieu-Daudé
2026-11-05 16:03   ` Alex Bennée
2026-11-05 12:51 ` [PATCH v2 04/17] tests/unit/visitor: Replace deprecated sprintf() with snprintf() Philippe Mathieu-Daudé
2026-11-05 12:51 ` [PATCH v2 05/17] hw/ppc/vof: " Philippe Mathieu-Daudé
2026-11-05 12:51 ` [PATCH v2 06/17] hw/usb/hcd-ohci: " Philippe Mathieu-Daudé
2026-11-05 12:51 ` [PATCH v2 07/17] hw/riscv/platform-ref: Replace deprecated sprintf with g_strdup_printf Philippe Mathieu-Daudé
2026-11-05 16:05   ` Alex Bennée
2026-11-05 23:17   ` Alistair Francis
2026-11-05 12:51 ` [PATCH v2 08/17] hw/vfio/pci: Replace deprecated sprintf() with g_strdup_printf() Philippe Mathieu-Daudé
2026-11-05 13:25   ` Cédric Le Goater
2026-11-05 12:51 ` [PATCH v2 09/17] hw/ppc/spapr: " Philippe Mathieu-Daudé
2026-11-05 16:08   ` Alex Bennée
2026-11-05 12:51 ` [PATCH v2 10/17] hw/net/eepro100: Replace deprecated sprintf() with snprintf() Philippe Mathieu-Daudé
2026-11-05 16:12   ` Alex Bennée
2026-11-05 12:51 ` [PATCH v2 11/17] hw/net/rocker: " Philippe Mathieu-Daudé
2026-11-05 12:51 ` [PATCH v2 12/17] hw/scsi: " Philippe Mathieu-Daudé
2026-11-05 12:51 ` [PATCH v2 13/17] target/xtensa: " Philippe Mathieu-Daudé
2026-11-06  2:25   ` Max Filippov
2026-11-05 12:51 ` [PATCH v2 14/17] target/m68k: " Philippe Mathieu-Daudé
2026-11-05 12:52 ` [PATCH v2 15/17] target/rx: " Philippe Mathieu-Daudé
2026-11-06  8:37   ` yoshinori.sato
2026-11-05 12:52 ` [PATCH v2 16/17] libdecnumber: " Philippe Mathieu-Daudé
2026-11-05 12:52 ` Philippe Mathieu-Daudé [this message]
2026-11-05 15:29   ` [PATCH v2 17/17] qga/vss-win32: Replace deprecated sprintf() by StrCatBuffA() Kostiantyn Kostiuk
2026-11-05 19:59     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261105125203.40320-18-philmd@oss.qualcomm.com \
    --to=philmd@oss.qualcomm.com \
    --cc=kkostiuk@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.