From: Simon Horman <horms@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: sashiko-reviews@lists.linux.dev, netdev@vger.kernel.org,
bpf@vger.kernel.org, virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
Eugenio Perez <eperezma@redhat.com>,
Eric Dumazet <edumazet@kernel.org>
Subject: Re: [PATCH net 2/2] net: validate xmit skbs in generic_xdp_tx()
Date: Thu, 5 Nov 2026 13:31:08 +0000 [thread overview]
Message-ID: <20261105133108.GR865646@horms.kernel.org> (raw)
In-Reply-To: <egj2sjr6palh4p7daxvw7t547eghkl5mzprjaaxzijtzg2ghpo@wahu23aivld3>
On Tue, Nov 03, 2026 at 01:39:26PM +0200, Vladimir Oltean wrote:
> On Sat, Oct 31, 2026 at 11:48:09AM +0000, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
> > - [High] net: out-of-bounds read in qdisc_pkt_len_segs_init() via generic_xdp_tx()
> > - [High] net: shared skb->head corruption on cloned broadcast skbs in generic_xdp_tx()
> > - [Medium] net: WARN_ONCE in skb_checksum_help() from generic_xdp_tx() after XDP resize
...
> In short, I don't think this patch makes any of the above problems worse
> than they already are.
I also believe that response can be extened to the overlapping feedback
provided by netdev-bot+sashiko@kernel.org
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-11-05 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 11:47 [PATCH net 1/2] net: pass the XDP action to generic_xdp_tx() for tracing Vladimir Oltean
2026-10-30 11:47 ` [PATCH net 2/2] net: validate xmit skbs in generic_xdp_tx() Vladimir Oltean
2026-10-31 11:48 ` sashiko-bot
2026-11-03 11:39 ` Vladimir Oltean
2026-11-05 13:31 ` Simon Horman [this message]
2026-11-05 13:50 ` Vladimir Oltean
2026-11-03 12:24 ` netdev-bot+sashiko
2026-10-31 11:48 ` [PATCH net 1/2] net: pass the XDP action to generic_xdp_tx() for tracing sashiko-bot
2026-11-05 13:23 ` Simon Horman
2026-11-10 17:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105133108.GR865646@horms.kernel.org \
--to=horms@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.