All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Sandeep Haemoon <sandeeph@loljews.com>
Cc: netdev@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: ethernet: mtk_eth_soc: skip page_pool for
Date: Thu, 5 Nov 2026 14:27:42 +0000	[thread overview]
Message-ID: <20261105142742.GU865646@horms.kernel.org> (raw)
In-Reply-To: <patch-fdfc120d5c46c3e5d484cbff30f63316@loljews.com>

On Mon, Nov 02, 2026 at 12:48:46AM +0200, Sandeep Haemoon wrote:
> page_pool allocates order-0 pages and the pool is created with
> MTK_PP_MAX_BUF_SIZE.  Rings that need larger buffers (9K jumbo or the
> HW-LRO rings) cannot use it.  Only create/use a page_pool when
> ring->frag_size fits in a page; the large-buffer path already uses
> mtk_max_buf_alloc().
> 
> This is required by the 9K support in the previous patch; the
> large-buffer path it relies on comes from the MediaTek downstream
> series.
> 
> Link: https://github.com/mediatek/mtk-openwrt-feeds
> Signed-off-by: Sandeep Haemoon <sandeeph@loljews.com>

It may not be particularly important, but I do wonder
if the order of the patches in this patch-set should
be reversed: as it is 9k support seems to be added by 1/2
and fixed in 2/2.

That notwithstanding:

Reviewed-by: Simon Horman <horms@kernel.org>



  reply	other threads:[~2026-11-05 14:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-01 22:58 [PATCH net-next 0/2] net: ethernet: mtk_eth_soc: 9K jumbo frame support Sandeep Haemoon
2026-11-01 22:48 ` [PATCH net-next 1/2] net: ethernet: mtk_eth_soc: add 9K jumbo frame Sandeep Haemoon
2026-11-01 22:48   ` [PATCH net-next 2/2] net: ethernet: mtk_eth_soc: skip page_pool for Sandeep Haemoon
2026-11-05 14:27     ` Simon Horman [this message]
2026-11-05 14:26   ` [PATCH net-next 1/2] net: ethernet: mtk_eth_soc: add 9K jumbo frame Simon Horman
2026-11-05 22:22   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261105142742.GU865646@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=sandeeph@loljews.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.