From: "Denis V. Lunev" <den@openvz.org>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Denis V. Lunev" <den@openvz.org>,
"Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
Subject: [PATCH 2/3] block: add bdrv_child_notify_resize() to notify a single parent
Date: Thu, 5 Nov 2026 21:37:51 +0100 [thread overview]
Message-ID: <20261105203752.3169635-3-den@openvz.org> (raw)
In-Reply-To: <20261105203752.3169635-1-den@openvz.org>
From: Denis V. Lunev <den@openvz.org>
bdrv_co_parent_cb_resize() calls the resize hook of every parent of a
node. bdrv_replace_child_bs() needs to call it for one BdrvChild, and
from outside a coroutine.
Move the call into bdrv_co_child_notify_resize(), make the loop use it,
and add a co_wrapper for callers outside a coroutine.
No functional change.
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Denis V. Lunev <den@openvz.org>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>
Cc: Eric Blake <eblake@redhat.com>
Cc: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
---
block/io.c | 14 +++++++++++---
include/block/block_int-io.h | 9 +++++++++
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/block/io.c b/block/io.c
index 06b1fc13b9..ea77f34204 100644
--- a/block/io.c
+++ b/block/io.c
@@ -3634,6 +3634,16 @@ int coroutine_fn bdrv_co_copy_range(BdrvChild *src, int64_t src_offset,
bytes, read_flags, write_flags);
}
+void coroutine_fn bdrv_co_child_notify_resize(BdrvChild *c)
+{
+ IO_CODE();
+ assert_bdrv_graph_readable();
+
+ if (c->klass->resize) {
+ c->klass->resize(c);
+ }
+}
+
void coroutine_fn bdrv_co_parent_cb_resize(BlockDriverState *bs)
{
BdrvChild *c;
@@ -3642,9 +3652,7 @@ void coroutine_fn bdrv_co_parent_cb_resize(BlockDriverState *bs)
assert_bdrv_graph_readable();
QLIST_FOREACH(c, &bs->parents, next_parent) {
- if (c->klass->resize) {
- c->klass->resize(c);
- }
+ bdrv_co_child_notify_resize(c);
}
}
diff --git a/include/block/block_int-io.h b/include/block/block_int-io.h
index 95d0dd7a05..3cb72fecd4 100644
--- a/include/block/block_int-io.h
+++ b/include/block/block_int-io.h
@@ -197,6 +197,15 @@ void bdrv_bsc_fill(BlockDriverState *bs, int64_t offset, int64_t bytes);
void coroutine_fn GRAPH_RDLOCK
bdrv_co_parent_cb_resize(BlockDriverState *bs);
+/*
+ * Notify the parent behind @c that the size of its child changed.
+ */
+void coroutine_fn GRAPH_RDLOCK
+bdrv_co_child_notify_resize(BdrvChild *c);
+
+void co_wrapper_bdrv_rdlock
+bdrv_child_notify_resize(BdrvChild *c);
+
void co_wrapper_bdrv_rdlock
bdrv_parent_cb_resize(BlockDriverState *bs);
--
2.53.0
next prev parent reply other threads:[~2026-11-05 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 20:37 [PATCH 0/3] block: fix the size change notification in bdrv_replace_child_bs() Denis V. Lunev
2026-11-05 20:37 ` [PATCH 1/3] block: read the old child length after draining " Denis V. Lunev
2026-11-05 20:37 ` Denis V. Lunev [this message]
2026-11-05 20:37 ` [PATCH 3/3] block: notify only the replaced child " Denis V. Lunev
2026-11-17 11:00 ` [PATCH 0/3] block: fix the size change notification " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105203752.3169635-3-den@openvz.org \
--to=den@openvz.org \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.