From: Christoph Hellwig <hch@lst.de>
To: Haris Iqbal <haris.iqbal@linux.dev>
Cc: Mohamed Khalfella <mkhalfella@purestorage.com>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Keith Busch <kbusch@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [v3 for-next 1/3] block: Reject unknown status tags in error injection rules
Date: Fri, 6 Nov 2026 09:03:00 +0100 [thread overview]
Message-ID: <20261106080300.GA3696@lst.de> (raw)
In-Reply-To: <58a98f7d-b2c5-47b5-a372-0ab5afa6a8ed@linux.dev>
On Thu, Nov 05, 2026 at 09:00:27PM +0100, Haris Iqbal wrote:
>> Doing it this way will result in use-after-free. "tag" has already been
>> freed above.
>>
>> Maybe change tag_to_blk_status() to return an int (0 on success and
>> -EINVAL on failure) and use its return value without mapping it?
>
> I am not sure I get your suggestion completely. Even if we change the
> return type of tag_to_blk_status(), we would have to free the "tag" before
> returning.
Let's just ignore my suggestion as it obviously does not work.
next prev parent reply other threads:[~2026-11-06 8:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 22:16 [v3 for-next 0/3] block: delay support for error injection Md Haris Iqbal
2026-09-28 22:16 ` [v3 for-next 1/3] block: Reject unknown status tags in error injection rules Md Haris Iqbal
2026-10-05 8:49 ` Christoph Hellwig
2026-10-20 22:34 ` Mohamed Khalfella
2026-11-05 20:00 ` Haris Iqbal
2026-11-05 20:18 ` Mohamed Khalfella
2026-11-05 22:08 ` Haris Iqbal
2026-11-06 8:03 ` Christoph Hellwig [this message]
2026-09-28 22:16 ` [v3 for-next 2/3] block: allow error injection rules to delay bios Md Haris Iqbal
2026-10-05 8:56 ` Christoph Hellwig
2026-10-20 23:34 ` Mohamed Khalfella
2026-11-05 21:26 ` Haris Iqbal
2026-09-28 22:16 ` [v3 for-next 3/3] Documentation: block: document error injection delay feature Md Haris Iqbal
2026-10-05 8:56 ` Christoph Hellwig
2026-10-14 3:04 ` [v3 for-next 0/3] block: delay support for error injection shinichiro.kawasaki
2026-10-14 11:57 ` Shin'ichiro Kawasaki
2026-10-22 20:23 ` Mohamed Khalfella
2026-10-28 14:51 ` Haris Iqbal
2026-10-28 17:19 ` Mohamed Khalfella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261106080300.GA3696@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=haris.iqbal@linux.dev \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkhalfella@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.