From: Simon Horman <horms@kernel.org>
To: Vadluri Mukunda <vmukunda@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sunil Goutham <sgoutham@marvell.com>,
Ratheesh Kannoth <rkannoth@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Suman Ghosh <sumang@marvell.com>
Subject: Re: [PATCH net v2] octeontx2-af: skip NPC_AF_MATCH_STATX access on cn20k
Date: Fri, 6 Nov 2026 12:09:18 +0000 [thread overview]
Message-ID: <20261106120918.GH865646@horms.kernel.org> (raw)
In-Reply-To: <20261103091831.914393-1-vmukunda@marvell.com>
On Tue, Nov 03, 2026 at 09:18:31AM +0000, Vadluri Mukunda wrote:
> From: Subbaraya Sundeep <sbhatta@marvell.com>
>
> NPC_AF_MATCH_STATX is not present on cn20k silicon, and cn20k does
> not set up an RX miss action counter. Two paths still access it:
> the npc_delete_flow mailbox, which reads the counter of the deleted
> rule, and the rx_miss_act_stats debugfs file, which would read
> counter 0. Avoid the access on cn20k. Counter support for cn20k is
> left for later.
>
> Found by code inspection. The issue was not triggered on hardware.
> Compile tested only; not tested on real hardware.
>
> Fixes: 4e527f1e5c15 ("octeontx2-af: npc: cn20k: Add new mailboxes for CN20K silicon")
> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> Signed-off-by: Vadluri Mukunda <vmukunda@marvell.com>
> ---
> v2:
> - Fixes tag now points to the upstream commit
> - Also skip creating the rx_miss_act_stats debugfs file on cn20k
> - Use full name in Signed-off-by
> - Add how the issue was found and what testing was done
> v1: https://lore.kernel.org/netdev/20261026035140.666684-1-vmukunda@marvell.com/
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-11-06 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 9:18 [PATCH net v2] octeontx2-af: skip NPC_AF_MATCH_STATX access on cn20k Vadluri Mukunda
2026-11-06 12:09 ` Simon Horman [this message]
2026-11-06 14:02 ` Nicolai Buchwitz
2026-11-10 2:55 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261106120918.GH865646@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=gakula@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
--cc=vmukunda@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.