From: Simon Horman <horms@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: Elad Nachman <enachman@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] net: prestera: release the ruleset in prestera_flower_prio_get
Date: Fri, 6 Nov 2026 12:17:31 +0000 [thread overview]
Message-ID: <20261106121731.GI865646@horms.kernel.org> (raw)
In-Reply-To: <20261103100532.1309990-1-vulab@iscas.ac.cn>
On Tue, Nov 03, 2026 at 10:05:32AM +0000, Wentao Liang wrote:
> prestera_flower_prio_get() looks up the ruleset with
> prestera_acl_ruleset_lookup(), which increments its reference count,
> but returns without calling prestera_acl_ruleset_put().
>
> The ruleset reference is leaked on every successful priority query.
> Release it after the priority range has been copied out.
>
> Fixes: 44af95718fed ("net: prestera: manage matchall and flower priorities")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Hi Wentao,
While I have reservations about the large number of patches you
have sent to netdev in the past days, as others have commented,
I do believe this patch is correct.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-11-06 12:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 10:05 [PATCH] net: prestera: release the ruleset in prestera_flower_prio_get Wentao Liang
2026-11-03 10:09 ` netdev-bot+sinfo
2026-11-03 10:26 ` Krzysztof Kozlowski
2026-11-06 12:17 ` Simon Horman [this message]
2026-11-07 5:35 ` Wentao Liang
2026-11-06 23:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261106121731.GI865646@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=enachman@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.