From: Jakub Kicinski <kuba@kernel.org>
To: Linkui Xiao <xiaolinkui@126.com>
Cc: jiri@resnulli.us, davem@davemloft.net, edumazet@kernel.org,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Linkui Xiao <xiaolinkui@kylinos.cn>
Subject: Re: [PATCH net-next v2 0/2] devlink: do not dereference a missing param item or shared buffer
Date: Fri, 6 Nov 2026 12:59:04 -0800 [thread overview]
Message-ID: <20261106125904.2961bc3b@kernel.org> (raw)
In-Reply-To: <20261102131505.611343-1-xiaolinkui@126.com>
On Mon, 2 Nov 2026 21:15:03 +0800 Linkui Xiao wrote:
> Two devlink helpers look an object up by id or index, warn when the
> lookup fails, and then pass the NULL result to code that dereferences
> it. A driver mistake (a param_id that was never registered, an sb_index
> that was never registered or is unregistered twice) therefore costs an
> oops instead of a warning.
This is a very low value contribution.
Please think harder whether the changes you're making are worth
community's time.
next prev parent reply other threads:[~2026-11-06 20:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 13:15 [PATCH net-next v2 0/2] devlink: do not dereference a missing param item or shared buffer Linkui Xiao
2026-11-02 13:15 ` [PATCH net-next v2 1/2] devlink: param: do not dereference a missing param item Linkui Xiao
2026-11-02 14:17 ` Ivan Vecera
2026-11-02 13:15 ` [PATCH net-next v2 2/2] devlink: sb: do not dereference a missing shared buffer Linkui Xiao
2026-11-02 14:17 ` Ivan Vecera
2026-11-06 20:59 ` Jakub Kicinski [this message]
2026-11-06 21:00 ` [PATCH net-next v2 0/2] devlink: do not dereference a missing param item or " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261106125904.2961bc3b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiaolinkui@126.com \
--cc=xiaolinkui@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.