All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "Romit Sagu" <romit@romitsagu.com>
Cc: <netdev@vger.kernel.org>, <linux@armlinux.org.uk>,
	<andrew@lunn.ch>, <hkallweit1@gmail.com>, <davem@davemloft.net>,
	<edumazet@kernel.org>, <pabeni@redhat.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [PATCH net-next] net: sfp: add quirk for OEM SFP+ONU-XGSPON
Date: Fri, 6 Nov 2026 13:04:42 -0800	[thread overview]
Message-ID: <20261106130442.5ad3327b@kernel.org> (raw)
In-Reply-To: <20261103011849.181392-1-romit@romitsagu.com>

On Tue,  3 Nov 2026 01:18:42 +0000 Romit Sagu wrote:
> This XGS-PON ONU stick (vendor OEM, part SFP+ONU-XGSPON)
> needs the same handling as other Potron-based modules. Without it,
> the module fails to connect and the kernal shows these errors:
> sfp sfp1: module transmit fault indicated
> sfp sfp1: module persistently indicates fault, disabling
> 
> This module requires TX_FAULT/LOS behaviour and boot delay tuning.
> Add a quirk using the existing sfp_fixup_potron.
> 
> Signed-off-by: Romit Sagu <romit@romitsagu.com>
> ---
>  drivers/net/phy/sfp.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index 85e57a16bb52..9435b25b54c9 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -623,6 +623,10 @@ static const struct sfp_quirk sfp_quirks[] = {
>  
>  	SFP_QUIRK_F("YV", "SFP+ONU-XGSPON", sfp_fixup_potron),
>  
> +	// OEM SFP+ONU-XGSPON is a XGS-PON ONT stick with broken TX_FAULT
> +	// and slow startup, just like potron.
> +	SFP_QUIRK_F("OEM", "SFP+ONU-XGSPON", sfp_fixup_potron),
> +
>  	// HORACO HC-10GE-113C uses Rollball protocol to talk to the PHY.
>  	SFP_QUIRK_F("OEM", "HC-10GE-113C", sfp_fixup_rollball),
>  

PS. AI also suggests mentioning LOS in the comment, since you have to
respin

https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261103011849.181392-1-romit@romitsagu.com

      parent reply	other threads:[~2026-11-06 21:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  1:18 [PATCH] [PATCH net-next] net: sfp: add quirk for OEM SFP+ONU-XGSPON Romit Sagu
2026-11-03  1:24 ` Andrew Lunn
2026-11-06 21:03 ` Jakub Kicinski
2026-11-06 21:04 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106130442.5ad3327b@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=romit@romitsagu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.