Re: [PATCH 37/37] hw/arm/mpam: Implement query-mpam-cache

[Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>]

On Fri, 16 Oct 2026 18:10:57 +0800
Jinjie Ruan <2118537295@qq.com> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Implement the query-mpam-cache QMP command: walk the QOM tree for
> mpam-msc-cache devices and report each via mpam_cache_fill_info()
> (with the per-RIS register state and the configured CPBM bitmaps),
> building on the generated header now included from the device
> contract header.
> 
> Based on an RFC series by Jonathan Cameron, adapted to the current
> qapi documentation rules.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
>  hw/arm/meson.build    |  5 ++--
>  hw/arm/mpam-qapi.c    | 62 ++++++++++++++++++++++++++++++++++++++++
>  hw/arm/mpam.c         | 66 +++++++++++++++++++++++++++++++++++++++++++
>  include/hw/arm/mpam.h |  3 ++
>  4 files changed, 134 insertions(+), 2 deletions(-)
>  create mode 100644 hw/arm/mpam-qapi.c
> 
> diff --git a/hw/arm/meson.build b/hw/arm/meson.build
> index adf9146..da73546 100644
> --- a/hw/arm/meson.build
> +++ b/hw/arm/meson.build
> @@ -106,8 +106,9 @@ arm_common_ss.add(when: 'CONFIG_NETDUINO2', if_true: files('netduino2.c'))
>  arm_common_ss.add(when: 'CONFIG_RASPI', if_true: files('bcm2835_peripherals.c'))
>  arm_common_ss.add(when: 'CONFIG_RASPI', if_true: files('bcm2838_peripherals.c'))
>  arm_common_ss.add(when: 'CONFIG_STRONGARM', if_true: files('strongarm.c'))
> -arm_common_ss.add(when: 'CONFIG_MPAM', if_true: files('mpam.c'))
> -arm_common_ss.add(files('mpam-qapi-stubs.c'))
> +arm_common_ss.add(when: 'CONFIG_MPAM', if_true: files('mpam.c', 'mpam-qapi.c'))
> +arm_common_ss.add(when: 'CONFIG_MPAM', if_false: files('mpam-qapi-stubs.c'))
> +arm_common_ss.add(when: 'CONFIG_ALL', if_true: files('mpam-qapi-stubs.c'))
This doesn't build with non arm targets. Needs an update to something like
drop the last two lines and replace with

stub_ss.add(files('mpam-qapi-stubs.c'))

Also I'd squash the previous path and this one to keep the build files simple.




>  arm_common_ss.add(when: 'CONFIG_SX1', if_true: files('omap_sx1.c'))
>  arm_common_ss.add(when: 'CONFIG_VERSATILE', if_true: files('versatilepb.c'))
>  arm_common_ss.add(when: 'CONFIG_VEXPRESS', if_true: files('vexpress.c'))