All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kyle Pepper <cochcoder@proton.me>
To: linux-bluetooth@vger.kernel.org
Cc: marcel@holtmann.org, luiz.von.dentz@gmail.com
Subject: [PATCH v2] shared/asha: prime volume before starting audio
Date: Sat, 07 Nov 2026 01:01:13 +0000	[thread overview]
Message-ID: <20261107010019.1162372-1-cochcoder@proton.me> (raw)
In-Reply-To: <20261028133131.262033-1-cochcoder@proton.me>

Prime the Volume characteristic with the cached volume before START so
both volume inputs are initialized when audio starts. Keep the write
best effort so a rejected volume write does not prevent START.

Assisted-by: OpenCode:gpt-6.1-sol
Assisted-by: Codex:gpt-6
---
v2: Drop the standalone mock test and redundant failure log.

Previous version:
https://lore.kernel.org/linux-bluetooth/20261028133131.262033-1-cochcoder@proton.me/

The unchanged local harness rejects baseline and passes this version,
including ASan/UBSan and LTO checks. Full make check is blocked by an SDP
debug-symbol linker failure also reproduced on unchanged upstream.
No volume-only hardware ablation or new remote CI result is claimed.

 src/shared/asha.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/shared/asha.c b/src/shared/asha.c
index 79bb29bf9a..6310a8357d 100644
--- a/src/shared/asha.c
+++ b/src/shared/asha.c
@@ -262,6 +262,9 @@ unsigned int bt_asha_start(struct bt_asha *asha, bt_asha_cb_t cb,
 		return 0;
 	}
 
+	/* Some renderers require a Volume write before START. */
+	bt_asha_set_volume(asha, asha->volume);
+
 	ret = asha_send_acp(asha, acp_start_cmd, sizeof(acp_start_cmd), cb,
 			user_data);
 	if (ret < 0)

base-commit: a8067198717b38391ca183ed7f41a69ec4b81b6e
-- 
2.56.0



  parent reply	other threads:[~2026-11-07  1:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 13:31 [PATCH RESEND] shared/asha: prime volume before starting audio Kyle Pepper
2026-10-28 16:25 ` [RESEND] " bluez.test.bot
2026-11-07  1:01 ` Kyle Pepper [this message]
2026-11-07  2:51   ` [v2] " bluez.test.bot
2026-11-07  7:02   ` [PATCH v2] " cochcoder
2026-11-10 22:00   ` patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261107010019.1162372-1-cochcoder@proton.me \
    --to=cochcoder@proton.me \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.von.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.