[PATCH BlueZ v2] shared/asha: Send STOP without a response

[Kyle Pepper <cochcoder@proton.me>]

Avoid leaving a STOP Write Request pending after local state has been
reset. Send a Write Command using the existing helper instead.

ASHA specifies Write with response for STOP; this changes that procedure
and needs renderer STOP/restart validation.

Fixes: 9948168cca15 ("shared/asha: Don't wait for status notification on stop")
Assisted-by: OpenCode:gpt-6.1-sol
Assisted-by: Codex:gpt-6
---
v2: Drop the standalone mock test and redundant state-reset comment.
Keep the unchanged regression harness as local evidence.
Previous submission: https://lore.kernel.org/linux-bluetooth/20261028133034.261833-1-cochcoder@proton.me/

The ASHA AudioControlPoint table specifies Write with response for STOP.
Maintainer agreement on this deviation and renderer STOP/restart evidence
remain open. The local mock cannot establish protocol interoperability.
https://source.android.com/docs/core/connect/bluetooth/asha#AudioControlPoint

Pristine source fails the expected local mock assertion. Sent and reduced
source pass; reduced source also passes ASan/UBSan and LTO. Full make check
was not rerun: the preceding baseline review reproduced an SDP linker
failure. No new hardware, remote CI or acceptance result is claimed.

 src/shared/asha.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/shared/asha.c b/src/shared/asha.c
index 79bb29bf9a..f1edc06444 100644
--- a/src/shared/asha.c
+++ b/src/shared/asha.c
@@ -284,8 +284,8 @@ unsigned int bt_asha_stop(struct bt_asha *asha)
 
 	asha->state = ASHA_STOPPED;
 
-	ret = asha_send_acp(asha, acp_stop_cmd, sizeof(acp_stop_cmd), NULL,
-			NULL);
+	ret = asha_send_acp_without_response(asha, acp_stop_cmd,
+					     sizeof(acp_stop_cmd));
 	asha_set_send_status(asha, false);
 
 	/* We reset our state without waiting for a response */

base-commit: a8067198717b38391ca183ed7f41a69ec4b81b6e
-- 
2.56.0