From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794050862; b=cqx+HqjxoZNkrpUtRMaZfj269gQxWjkqK3ydzt23vZ9G7yXnEpD/TtVV2G54H168frap mm35ixKpzGFmyGyC3Xnu1L+FdCVd8srf2cd9svgMUnbpyGmRwEe9nzBLOWfFvsoybzemT urxwbpTJ45+MlOIs+Chq5Y0JfaUeumV2OPvgUjtdcYL+Kou2w9z/+zv7kH8kGdqlhoD0h +fb5S4QVUKxVHD8tkElEl3M9IOyLMXID6TjOxivikzBsCaC17Y6aMRrW+TF0D+DvPeFyI Dgzk9PJfO8NPOI5yzrJATrxeGSb1MV/gt4pzR32g7bunFcSo+zBxGOANQuoULI5P/9Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794050862; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=DbkHAGjR6g9go8+RjgQr56+2CxfKnAC10aiuFOu0pbA=; b=gFHmEnZlgf7Y9Y4UCm3K1tPZMOO794KNF1977K23DUWF11dUnGVGx1181u2myGIGwjaI d+mtTPSP6XXejcey5iiyafbVx/UbNt2LuYhm/sAqFEdlfmORaAyU/AUNhQwWTr0OS9Ry+ byNYV0eX8CbS7xOFi6aB0JuzVNUS/pZ2v9zugm5TYzDKrCai0kaLaVzZ0jitnnLFRjnco Q4Btu5NjifByhxV/STpXN1nQJ98KXq7pMl4ibg3VRxtcNnmTw7rRXpJ740lRl7q7knOdX kBIbGut3ECfA7P7xYH6N51AQGwLtc8F79EKMeuFAc5Y6Tllk9z1P3T5ESQ+872R22RQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="dDAVs90/"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22D34606A326 for ; Sat, 7 Nov 2026 11:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dDAVs90/ Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2432E1F0089F; Sat, 7 Nov 2026 11:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794050861; bh=DbkHAGjR6g9go8+RjgQr56+2CxfKnAC10aiuFOu0pbA=; h=From:To:Cc:Subject:Date; b=dDAVs90/6gqyuUDX0JnW5aYSZvpOzrgfGVdohb0bd0AK6FGZHI3eQZAgN/liq+3M8 dbkiyS3kAoLuF6Mks5JiF+Zkiid8HJWx19NVRvhpDONMYy0CAbRgMO/b0SZ/DDveZU ShZc8kszgfMT3IkPVt+piga5FDWUbNsT6N/BTk/AqovJMqeG4KauCAELS4SRok1W8r 1jDeZCTi6WMo86lFGzkf0YRF02FEDSVnZu7P0xYbKFZe6G7h+SiceeA8NGd+5o9N9Q 0EqkFzQv/9WMGVSaxt2eqhOCnK3GnfjIDM775CigzOSomFIBE5pbuNP2cWwH43H3lg DS03NWRmMdbvQ== From: Sasha Levin To: cel@kernel.org, danny_pidutti@hotmail.com, danny@lightningiq.io, bcodding@hammerspace.com, brauner@kernel.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] exportfs: Release the get_name() directory file synchronously" failed to apply to 5.10-stable tree Date: Sat, 7 Nov 2026 06:27:39 -0500 Message-ID: <20261107062739-failed-5.10-49184daab016@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 49184daab01674ca400cbef58ee101dba6dbbb9d # git commit -s git send-email --to '' --in-reply-to '20261107062739-failed-5.10-49184daab016@kernel.org' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 49184daab01674ca400cbef58ee101dba6dbbb9d Mon Sep 17 00:00:00 2001 From: Chuck Lever Date: Thu, 8 Oct 2026 10:09:03 -0400 Subject: [PATCH] exportfs: Release the get_name() directory file synchronously get_name() opens the parent directory with dentry_open() and releases it with fput(). From a kernel thread, fput() defers the final __fput() to the delayed_fput work item. NFSD threads are kernel threads, and NFSD reaches get_name() through exportfs_decode_fh() whenever a file handle's dentry is not connected to the root. On a filesystem with more directories than the dcache retains, nearly every READDIRPLUS needs a reconnect. The deferred releases arrive faster than the work item retires them, and each pending file pins the directory's readdir state. On ext4 that state is the htree fname cache for the last leaf block read. A 64-thread NFSv3 server under a parallel tree walk showed unreclaimable slab growing by about 90 MB per second, and the same workload on a 5.15 kernel ended in a global OOM. Commit 5ff318f645eb ("nfsd: use __fput_sync() to avoid delayed closing of files.") stopped NFSD's own closes from feeding the delayed_fput queue but did not cover the exportfs reconnect path. Release the file with __fput_sync(). get_name() opened the file itself, read-only, on a directory, so __fput() involves nothing that could wait on the caller. Note for LTS backports: Kernels before v6.6 need the __fput_sync() call guarded by current->flags & PF_KTHREAD, with a plain fput() otherwise. Fixes: 4a9d4b024a31 ("switch fput to task_work_add") Cc: stable@vger.kernel.org # see above, needs adjustments for < v6.2 Reported-by: Danny Pidutti Closes: https://lore.kernel.org/linux-fsdevel/DS4PR04MB9846BA3C16BC5ACED8B589228D952@DS4PR04MB9846.namprd04.prod.outlook.com/ Tested-by: Danny Pidutti Reviewed-by: Benjamin Coddington Signed-off-by: Chuck Lever Link: https://patch.msgid.link/20261008140903.2784-1-cel@kernel.org Signed-off-by: Christian Brauner (Amutable) --- fs/exportfs/expfs.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c index eafd99507afee..b5768f94fbb59 100644 --- a/fs/exportfs/expfs.c +++ b/fs/exportfs/expfs.c @@ -336,7 +336,11 @@ static int get_name(const struct path *path, char *name, struct dentry *child) } out_close: - fput(file); + /* + * @file is the read-only directory opened above, so __fput() + * cannot block on anything the caller holds. + */ + __fput_sync(file); out: return error; } -- 2.53.0