[android-common:android15-6.6 53/53] drivers/android/wrapfd.c:788:32-49: opportunity for str_yes_no(ctx -> allow_guests)

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: cros-kernel-buildreports@googlegroups.com

Hi Suren,

First bad commit (maybe != root cause):

tree:   https://android.googlesource.com/kernel/common android15-6.6
head:   bc10f2ae3a89cd46c1069ed99b65df424ba3d3db
commit: 0513c5d5a13918d0326f9586ef6edad1872a6c98 [53/53] ANDROID: drivers/wrapfd: fix dmabuf_content_load and use kvec for loading
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
config: i386-randconfig-r2111-20261107 (https://download.01.org/0day-ci/archive/20261107/202611070754.AdFqlCZk-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202611070754.AdFqlCZk-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/android/wrapfd.c:788:32-49: opportunity for str_yes_no(ctx -> allow_guests)

vim +788 drivers/android/wrapfd.c

dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  773  
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  774  #ifdef CONFIG_PROC_FS
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  775  static void wrap_show_fdinfo(struct seq_file *m, struct file *file)
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  776  {
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  777  	struct wrap_ctx *ctx = file->private_data;
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  778  
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  779  	spin_lock(&ctx->lock);
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  780  	if (ctx->owner.task) {
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  781  		seq_printf(m, "owner:\t%d\n", ctx->owner.task->pid);
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  782  	} else {
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  783  		if (ctx->owner.dev)
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  784  			seq_printf(m, "owner:\t<device>\n");
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  785  		else
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  786  			seq_printf(m, "owner:\t<none>\n");
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  787  	}
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21 @788  	seq_printf(m, "guests:\t%s\n", ctx->allow_guests ? "yes" : "no");
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  789  	seq_printf(m, "maps:\t%d\n", ctx->map_count);
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  790  	seq_printf(m, "empty:\t%s\n", ctx->content ? "no" : "yes");
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  791  	if (ctx->content) {
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  792  		struct wrap_content *content = ctx->content;
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  793  
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  794  		seq_printf(m, "rdonly:\t%s\n",
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  795  			   content->ops->is_writable(content) ? "no" : "yes");
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  796  		content->ops->show_fdinfo(content, m);
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  797  	}
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  798  	spin_unlock(&ctx->lock);
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  799  }
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  800  #endif
dcd6a28f187e49 Suren Baghdasaryan 2025-11-21  801  

:::::: The code at line 788 was first introduced by commit
:::::: dcd6a28f187e4931aff3c8f3889d9776961ced02 ANDROID: drivers/wrapfd: add wrapfd driver base code

:::::: TO: Suren Baghdasaryan <surenb@google.com>
:::::: CC: android-test-infra-autosubmit@system.gserviceaccount.com <android-test-infra-autosubmit@system.gserviceaccount.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki