Re: [PATCH] ASoC: Intel: Remove unused sst_ipc_msg_tx tracepoint

[Steven Rostedt <rostedt@goodmis.org>]

On Thu,  5 Nov 2026 15:51:18 +0200
Temitope obabi <obabitemitope765@gmail.com> wrote:

> The sst_ipc_msg_tx tracepoint has had no callers since commit 37465972015c
> ("ASoC: Intel: Remove unused DSP operations").
> 
> Tracepoints that are defined take up around 5K each, even if they are not
> used. Remove this unused tracepoint.

It looks like a lot more events were removed than just this event. Can
you read the git commit logs and try to see if what the general trace
events were tracing was removed. If that's the case then the change log
needs to give a little history of what the changes did and that the
code no longer exists for what these events were tracing.

Note, this project is not just about blindly removing unused
tracepoints. It's to look at what changed, analyze it, and show the
history that lead to why these tracepoints are no longer needed.

Thanks,

-- Steve


> 
> Fixes: 37465972015c ("ASoC: Intel: Remove unused DSP operations")
> Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
> ---
>  include/trace/events/intel-sst.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/include/trace/events/intel-sst.h b/include/trace/events/intel-sst.h
> index 0416e91f8181..c318ae9bc3c3 100644
> --- a/include/trace/events/intel-sst.h
> +++ b/include/trace/events/intel-sst.h
> @@ -33,14 +33,6 @@ DECLARE_EVENT_CLASS(sst_ipc_msg,
>  	TP_printk("0x%8.8x", (unsigned int)__entry->val)
>  );
>  
> -DEFINE_EVENT(sst_ipc_msg, sst_ipc_msg_tx,
> -
> -	TP_PROTO(unsigned int val),
> -
> -	TP_ARGS(val)
> -
> -);
> -
>  DEFINE_EVENT(sst_ipc_msg, sst_ipc_msg_rx,
>  
>  	TP_PROTO(unsigned int val),