Re: [PATCH v2] drm/xe: Remove unused xe_vm_restart tracepoint

[Steven Rostedt <rostedt@goodmis.org>]

On Mon,  2 Nov 2026 00:05:17 +0530
Torra Sowmya <sowmyatorra@gmail.com> wrote:

> Commit f3e9b1f43458 ("drm/xe: Remove async worker and rework sync
> binds") removed the call to trace_xe_vm_restart(), but left the
> event definition behind.
> 
> Remove the unused definition from xe_trace_bo.h to avoid generating
> code and data for an event that has no callers.
> 
> With the tested x86-64 configuration, size reports a reduction of
> 436 bytes in xe_trace_bo.o, from 20262 to 19826 bytes: 140 bytes
> in text and 296 bytes in data.

That looks about right. The DEFINE_EVENT() is not as big as a
TRACE_EVENT() (in fact, that's why DEFINE_EVENT exists).

> 

Please add:

Fixes: f3e9b1f43458 ("drm/xe: Remove async worker and rework sync binds")

but other than that, looks good.

Thanks,

-- Steve

> Signed-off-by: Torra Sowmya <sowmyatorra@gmail.com>
> ---
> Changes in v2:
> - Add the measured object-size reduction to the commit message:
>   436 bytes in xe_trace_bo.o (140 text, 296 data).
> 
>  drivers/gpu/drm/xe/xe_trace_bo.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_trace_bo.h b/drivers/gpu/drm/xe/xe_trace_bo.h
> index 86323cf3be2c..fa91dd2b2174 100644
> --- a/drivers/gpu/drm/xe/xe_trace_bo.h
> +++ b/drivers/gpu/drm/xe/xe_trace_bo.h
> @@ -228,11 +228,6 @@ DEFINE_EVENT(xe_vm, xe_vm_cpu_bind,
>  	     TP_ARGS(vm)
>  );
>  
> -DEFINE_EVENT(xe_vm, xe_vm_restart,
> -	     TP_PROTO(struct xe_vm *vm),
> -	     TP_ARGS(vm)
> -);
> -
>  DEFINE_EVENT(xe_vm, xe_vm_rebind_worker_enter,
>  	     TP_PROTO(struct xe_vm *vm),
>  	     TP_ARGS(vm)