Re: [PATCH v3] nfs: Only define atomic open tracepoints when NFSv4 is enabled

[Steven Rostedt <rostedt@goodmis.org>]

On Sun,  1 Nov 2026 05:38:43 +0530
pavankumaryalagada@gmail.com wrote:

> From: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
> 
> Tracepoint definitions consume kernel memory even when they are not
> used. When tracepoints are only used in code compiled under a specific
> configuration, their definitions should also be guarded by the same
> configuration to avoid wasting memory.
> 
> The nfs_atomic_open_enter and nfs_atomic_open_exit tracepoints are
> only used in nfs_atomic_open() in fs/nfs/dir.c, which is compiled
> only when CONFIG_NFS_V4 is enabled. Guard their definitions with

Could you reword the above slightly, as I read the "which is complied"
to be fs/nfs/dir.c and not the function. Perhaps just remove the "in
fs/nfs/dir.c" part. The nfs_atomic_open() should be unique enough to
know where the issue is.

Thanks,

-- Steve


> the same config to avoid unused tracepoints and reduce memory usage
> by approximately 8 KiB.
> 
> Fixes: 6e0d0be715fe ("NFS: Add event tracing for generic NFS lookups")
> Signed-off-by: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>