Re: [PATCH] libtracefs: Pass the pipe size by value to F_SETPIPE_SZ

[Steven Rostedt <rostedt@goodmis.org>]

On Sat, 7 Nov 2026 17:40:11 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> >  	if (tfs_str_read_file("/proc/sys/fs/pipe-max-size", &buf, false) > 0) {
> >  		int size = atoi(buf);
> > -		fcntl(tcpu->splice_pipe[0], F_SETPIPE_SZ, &size);
> > +
> > +		/* F_SETPIPE_SZ takes the size itself, not a pointer to it */  
> 
> Nit. You don't need to add comments to bug fixes. That is, the above
> comment is useless.

Let me rephrase that. You can add comments to bug fixes. What I meant
was, the above comment is basically stating what was fixed, which is
useless for those looking at the code after the update.

-- Steve

> 
> 
> > +		fcntl(tcpu->splice_pipe[0], F_SETPIPE_SZ, size);
> >  		free(buf);
> >  	}