From: Eric Biggers <ebiggers@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: fsverity@lists.linux.dev, Andrey Albershteyn <aalbersh@kernel.org>
Subject: Re: [PATCH 6.1] fsverity: Explicitly require FMODE_READ to retrieve hashes
Date: Sat, 7 Nov 2026 11:25:56 -0800 [thread overview]
Message-ID: <20261107192556.GC6049@quark> (raw)
In-Reply-To: <sashiko-outbox-203203@kernel.org>
On Sat, Nov 07, 2026 at 07:21:27PM +0000, sashiko-bot@kernel.org wrote:
> [Severity: Medium]
> Does fsverity_ioctl_enable() also need an explicit FMODE_READ check in this
> branch?
>
> In mainline, fsverity_ioctl_enable() gained a check for FMODE_READ when
> Merkle tree construction was converted to use __kernel_read(). That
> change is not in this tree, where fsverity_ioctl_enable() only checks
> file_permission(filp, MAY_WRITE) and deny_write_access(filp), and
> build_merkle_tree_level() reads directly from the page cache via
> read_file_data_page().
I'll consider backporting 04839139213c ("fsverity: reject
FS_IOC_ENABLE_VERITY on mode 3 fds") separately. It is independent of
this patch.
- Eric
prev parent reply other threads:[~2026-11-07 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 19:10 [PATCH 6.1] fsverity: Explicitly require FMODE_READ to retrieve hashes Eric Biggers
2026-11-07 19:21 ` sashiko-bot
2026-11-07 19:25 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261107192556.GC6049@quark \
--to=ebiggers@kernel.org \
--cc=aalbersh@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.