From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Martin Willi <martin@strongswan.org>,
Antonio Quartulli <antonio@mandelbit.com>
Subject: Re: [PATCH] lib/crypto: x86/chacha: Avoid overly-narrow keystream XORs
Date: Sat, 7 Nov 2026 13:46:26 -0800 [thread overview]
Message-ID: <20261107214626.GG137269@quark> (raw)
In-Reply-To: <20261104065703.247316-1-ebiggers@kernel.org>
On Tue, Nov 03, 2026 at 10:57:03PM -0800, Eric Biggers wrote:
> chacha_2block_xor_avx2(), chacha_4block_xor_avx2(),
> chacha_2block_xor_avx512vl(), and chacha_4block_xor_avx512vl() currently
> XOR the data with the keystream 128 bits at a time. This is
> unnecessarily narrow; the same functions already use 256-bit vectors
> elsewhere. Do it 256 bits at a time instead, which is more efficient.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> lib/crypto/x86/chacha-avx2-x86_64.S | 220 +++++++++-----------------
> lib/crypto/x86/chacha-avx512-x86_64.S | 220 +++++++++-----------------
> 2 files changed, 150 insertions(+), 290 deletions(-)
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next
- Eric
prev parent reply other threads:[~2026-11-07 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 6:57 [PATCH] lib/crypto: x86/chacha: Avoid overly-narrow keystream XORs Eric Biggers
2026-11-05 9:44 ` Antonio Quartulli
2026-11-07 21:46 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261107214626.GG137269@quark \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=antonio@mandelbit.com \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=martin@strongswan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.