All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rishab Pradeep <rishab@rispop.dev>
To: qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org,
	Alistair Francis <alistair.francis@wdc.com>,
	Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Weiwei Li <liwei1518@gmail.com>,
	Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
	Chao Liu <chao.liu@processmission.com>,
	Tarun Patanjali <tarun.patanjali@utexas.edu>,
	Chris Elwood <christopher.elwood2024@gmail.com>
Subject: Re: [PATCH v2 2/2] target/riscv: Apply pointer masking to SSPUSH/SSPOPCHK addresses
Date: Sun,  8 Nov 2026 22:35:21 -0600	[thread overview]
Message-ID: <20261109043521.15730-1-rishab@rispop.dev> (raw)
In-Reply-To: <20261108064641.179764-3-rishab@rispop.dev>

Sashiko suggested a Fixes tag pointing at f06bfe3dc38c ("target/riscv:
implement zicfiss instructions"). I agree this needs a Fixes tag, but
I think the right target is the pointer-masking commit rather than the
zicfiss one. Zicfiss predates it, and its ssp accesses were correct
until get_address() started applying the ignore transformation without
covering ssp:

Fixes: 4d501a7a7fb4 ("target/riscv: Update address modify functions to take into account pointer masking")

Alistair, could you add this when applying, or would you prefer a v3?

Thanks,
Rishab


  parent reply	other threads:[~2026-11-09  4:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  6:46 [PATCH v2 0/2] target/riscv: Apply pointer masking to SSPUSH/SSPOPCHK Rishab Pradeep
2026-11-08  6:46 ` [PATCH v2 1/2] target/riscv: Factor out pointer-masking address adjustment Rishab Pradeep
2026-11-12  4:37   ` Alistair Francis
2026-11-08  6:46 ` [PATCH v2 2/2] target/riscv: Apply pointer masking to SSPUSH/SSPOPCHK addresses Rishab Pradeep
2026-11-08 20:39   ` Daniel Henrique Barboza
2026-11-09  4:35   ` Rishab Pradeep [this message]
2026-11-12  4:45     ` Alistair Francis
2026-11-12  4:38   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261109043521.15730-1-rishab@rispop.dev \
    --to=rishab@rispop.dev \
    --cc=alistair.francis@wdc.com \
    --cc=chao.liu@processmission.com \
    --cc=christopher.elwood2024@gmail.com \
    --cc=daniel.barboza@oss.qualcomm.com \
    --cc=liwei1518@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=tarun.patanjali@utexas.edu \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.