From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.10 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794199441; b=lm3yNUwDIW8ez7VF2l+2knDQcT4DmXnoTrCwpNs9f+ntdj9e0pqfyr1xikxpBWfk+dDk F8BvZeKZincFlSDQSiZP8jSARZa91lVDkKxoUvprwUM4jWocBO2ONtsYFUHlBztKAzDQ7 QxyCZx8P2DatoW9oCG8KEEzx++PBYhPYK/yF6558vtEbTnSdAbg2+RPQWN4DNYAm+Nhur PVB3fhmQ6vAS14HFKu/gMIwAPpvlgdAcCicYBjuT1RmoLKjLOvdDkUUIIFtxclhIHfvXO br5TW6d4sUv7ySj8jMOVU/br2QcQdi4zwUnNlGxlEQQ7/tY0tLagrjNyebAN7VTVetQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794199441; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Received:Date:From:To: Cc:Subject:Message-ID:User-Agent; bh=y/Hadae/HtLAHf3di7VyuclJltIQby88CDdDeEmehOo=; b=uIB29fOWg3O7gVioBU/ESNIQfvUmCA56uAIiuiSx5nLOU8o+rqcRoD5ozUs4DSg81riE M3cMJnKtQLTbOs+IK50ezgyuW+9ZXq4XZN5K7juW5lW++hPrLe7FnrIAKYUJHW9+pvOMF B5P/rijr7HDKUqLsCnUpQyQ3bEtP1ryji4eyuMvfucztDpaRUhqWQmaZWjpTKL7kQJKz4 hPNhxHTWQ9T60EbiOuQ3CAPZmpW8SAAchSuhe7xZcrNPz6pfZqa6vc21fz3E7S88rqXNJ 4WGITY90Fa2hg+JwqtCjL0r0DyEoOS0V1MtX8H/cVRb+Um0pUWb2d0YYtoawBpxevaw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=KH3O4If1; arc=none smtp.remote-ip=192.198.163.10 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C69E606A31C for ; Mon, 9 Nov 2026 04:44:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8C69E606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=KH3O4If1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1794199441; x=1825735441; h=date:from:to:cc:subject:message-id; bh=doIfc8z0YsLuKphz8y6RGTx2hva51WT5O4tyYAM7iTE=; b=KH3O4If1kqIsggkObIhEPZtss18L2SHia96Jw7Meijb88iy+j1OPAwk1 2AYHGJkK62mNVPLqnJKjnlLMhwKuvSEEW4WRVD16X5jBM06cNY1sycz4f LgQAtQTP0/ZZD6b0o1LhdpEOJOZ9dUUjuj6puv3u2xsH5/924sGxFCfRj JIPs4QnvVLSXeaF2u1WMLNiCnmV6PDhqXfQL2JX6SGum49gS3lfBlgIkh eq5FFFFVKOcxVm/rElzcfi8t4ucJjaPbUCALk3cvtWz97K5avkjahr2tB 0ICKQeSCi2woQYWnogqgSf2hxclOJp7/+Z51MV6vkUWNMw83jsz1s2qzt g==; X-CSE-ConnectionGUID: dpkKrslJRoi9Q8dxnNY9Dg== X-CSE-MsgGUID: dmegSSDAScikZbQp3HyrHg== X-IronPort-AV: E=McAfee;i="6800,10657,11960"; a="2820218" X-IronPort-AV: E=Sophos;i="6.27,203,1787036400"; d="scan'208";a="2820218" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2026 20:44:00 -0800 X-CSE-ConnectionGUID: wZDqY4b/T8uei3+/zA62hw== X-CSE-MsgGUID: MiTnfyb5T0umQ6icEI3YKQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,203,1787036400"; d="scan'208";a="8349137" Received: from igk-lkp-server01.igk.intel.com (HELO 1db0d17a343c) ([10.211.93.152]) by fmviesa010.fm.intel.com with ESMTP; 08 Nov 2026 20:43:58 -0800 Received: from kbuild by 1db0d17a343c with local (Exim 4.98.2) (envelope-from ) id 1xQHEa-000000000DP-27ED; Mon, 09 Nov 2026 04:43:56 +0000 Date: Mon, 09 Nov 2026 05:43:04 +0100 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: [mm:for-test 2/10] drivers/hid/hid-steam.c:557 steam_send_report_id() warn: check sign expansion for '__UNIQUE_ID_x__502' Message-ID: <202611090501.UwoAwtQL-lkp@intel.com> User-Agent: s-nail v14.9.25 X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Unfiltered warning: this smatch report is sent as-is and has not been reviewed for false positives, so please treat it with due skepticism. BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: David Hildenbrand TO: "Vlastimil Babka (SUSE)" CC: "David Hildenbrand (Arm)" tree: https://git.kernel.org/pub/scm/linux/kernel/git/mm/linux.git for-test head: 413ded9e05c4fe84254cee1d01aad70a428803c6 commit: 045ac46c238e70927cf9c20f61bb43437ac1c1da [2/10] Merge https://git.kernel.org/pub/scm/linux/kernel/git/mm/page_alloc.git page_alloc/for-next-fixes into for-next-fixes :::::: branch date: 10 hours ago :::::: commit date: 33 hours ago config: x86_64-randconfig-2200-20261109 (https://download.01.org/0day-ci/archive/20261109/202611090501.UwoAwtQL-lkp@intel.com/config) compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1) smatch: v0.5.0-9187-g5189e3fb If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202611090501.UwoAwtQL-lkp@intel.com/ smatch warnings: drivers/hid/hid-steam.c:557 steam_send_report_id() warn: check sign expansion for '__UNIQUE_ID_x__502' vim +/__UNIQUE_ID_x__502 +557 drivers/hid/hid-steam.c c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 516 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 517 static int steam_send_report_id(struct steam_device *steam, 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 518 u8 *cmd, int size, u8 report_id) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 519 { c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 520 struct hid_report *r; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 521 u8 *buf; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 522 unsigned int retries = 50; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 523 int ret; 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 524 u32 len; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 525 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 526 r = steam->hdev->report_enum[HID_FEATURE_REPORT].report_id_hash[report_id]; cd11d1a6114bd4 Lee Jones 2022-07-08 527 if (!r) { 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 528 hid_err(steam->hdev, "No HID_FEATURE_REPORT present for ID %u\n", report_id); cd11d1a6114bd4 Lee Jones 2022-07-08 529 return -EINVAL; cd11d1a6114bd4 Lee Jones 2022-07-08 530 } cd11d1a6114bd4 Lee Jones 2022-07-08 531 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 532 len = hid_report_len(r); 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 533 if (len < 64) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 534 return -EINVAL; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 535 c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 536 buf = hid_alloc_report_buf(r, GFP_KERNEL); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 537 if (!buf) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 538 return -ENOMEM; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 539 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 540 /* The report ID is always consistent */ 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 541 buf[0] = report_id; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 542 memcpy(buf + 1, cmd, size); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 543 de435b770cd949 Vicki Pfau 2026-07-29 544 hid_dbg(steam->hdev, "Sending report %*ph\n", size, cmd); de435b770cd949 Vicki Pfau 2026-07-29 545 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 546 if (!(steam->quirks & STEAM_QUIRK_IBEX)) 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 547 len += 1; 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 548 c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 549 /* c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 550 * Sometimes the wireless controller fails with EPIPE c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 551 * when sending a feature report. 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 552 * Doing a HID_REQ_SET_REPORT and waiting for a while c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 553 * seems to fix that. c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 554 */ c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 555 do { 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 556 ret = hid_hw_raw_request(steam->hdev, report_id, 0a80b4e8ec6a6e Vicki Pfau 2026-08-11 @557 buf, max(size + 1, len), c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 558 HID_FEATURE_REPORT, HID_REQ_SET_REPORT); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 559 if (ret != -EPIPE) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 560 break; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 561 msleep(20); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 562 } while (--retries); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 563 c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 564 kfree(buf); cfa66cba6d02ff Vicki Pfau 2026-08-11 565 /* cfa66cba6d02ff Vicki Pfau 2026-08-11 566 * Don't log if the failure is -ENODEV, as this cfa66cba6d02ff Vicki Pfau 2026-08-11 567 * can happen normally on disconnect. cfa66cba6d02ff Vicki Pfau 2026-08-11 568 */ cfa66cba6d02ff Vicki Pfau 2026-08-11 569 if (ret < 0 && ret != -ENODEV) c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 570 hid_err(steam->hdev, "%s: error %d (%*ph)\n", __func__, c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 571 ret, size, cmd); c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 572 return ret; c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 573 } c164d6abf3841f Rodrigo Rivas Costa 2018-04-16 574 :::::: The code at line 557 was first introduced by commit :::::: 0a80b4e8ec6a6e40937c7abdf8fb2ebe6cc7c1e5 HID: steam: Initial 2026 Steam Controller support :::::: TO: Vicki Pfau :::::: CC: Jiri Kosina -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki